Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review of pointer areas #147

Closed
Tracked by #129
, #374 ,  #402
...
veillette opened this issue Jul 29, 2021 · 6 comments
Closed
Tracked by #129
, #374 ,  #402
...

review of pointer areas #147

veillette opened this issue Jul 29, 2021 · 6 comments
Assignees
@arouinfar
Labels
status:ready-for-review

Comments

@veillette
Copy link
Contributor

No description provided.

@veillette veillette mentioned this issue Jul 29, 2021
Closed
@veillette veillette changed the title review of pointer areas, see {{GITHUB_ISSUE_LINK}} review of pointer areas Jul 29, 2021
@veillette
Copy link
Contributor Author

image
image

@veillette
Copy link
Contributor Author

The show pointers do not overlap and seems large enough for most purposes.
The object and the optic are large and do not need to have larger pointer areas.

The second source on the object and the ruler Icon bounds were dilated manually.
All the other ones are using the default values.

@veillette veillette self-assigned this Jul 29, 2021
@veillette
Copy link
Contributor Author

Assigning to @arouinfar to review.

@veillette veillette assigned arouinfar and unassigned veillette Jul 29, 2021
@veillette veillette mentioned this issue Jul 30, 2021
Closed
@pixelzoom
Copy link
Contributor

pixelzoom commented Sep 18, 2021 •
edited
Loading

@arouinfar Let's hold off on this review until we're closer to publication.

pixelzoom added a commit that referenced this issue Oct 13, 2021
@pixelzoom
fix overlap of touchArea for all NumberControls, #147
7dd82de
pixelzoom added a commit that referenced this issue Feb 21, 2022
@pixelzoom
adjust touchArea, #147
fdf9a27
pixelzoom added a commit that referenced this issue Feb 21, 2022
@pixelzoom
adjust pointer areas, #147
5a7ff0f
pixelzoom added a commit that referenced this issue Feb 21, 2022
@pixelzoom
adjust pointer areas, #147
c2449ec
pixelzoom added a commit that referenced this issue Feb 21, 2022
@pixelzoom
adjust pointer areas, #147
40f2bda
@pixelzoom pixelzoom self-assigned this Feb 21, 2022
@pixelzoom
Copy link
Contributor

All UI components are present in the sim, and pointer areas have been adjusted. Ready for review.

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Feb 22, 2022
@arouinfar
Copy link
Contributor

The pointer areas look good with showPointerAreas and I didn't have any issues with the touch areas on my phone, so I'll go ahead and close.

@pixelzoom pixelzoom mentioned this issue Mar 15, 2022
Closed
85 tasks
@pixelzoom pixelzoom mentioned this issue Mar 23, 2022
Closed
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixelzoom @veillette @arouinfar