Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic Numbers in TargetNode and SourceObjectNode #132

Closed
veillette opened this issue Jul 27, 2021 · 1 comment
Closed

Magic Numbers in TargetNode and SourceObjectNode #132

veillette opened this issue Jul 27, 2021 · 1 comment
Assignees
@veillette

Comments

@veillette
Copy link
Contributor

As part of the work on #129, we should remove most (all?) magic numbers that are related to the positioning of the objects, and images.
@veillette veillette self-assigned this Jul 27, 2021
veillette added a commit that referenced this issue Jul 27, 2021
@veillette
add positionOffset and dimensions to the Representation (see #24 and #…
dba3ffc 
…132)
@veillette
Copy link
Contributor Author

There are no more magic numbers in TargetNode and SourceObjectNode has all its constant hoisted. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veillette veillette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@veillette