review comments, #154

phetsims · Aug 5, 2021 · e85490b · e85490b
1 parent 4cb1027
commit e85490b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/js/common/model/Target.js b/js/common/model/Target.js
@@ -22,7 +22,7 @@ class Target extends EnabledComponent {
   /**
    * @param {Property.<Vector2>} objectPositionProperty - position of the object/source
    * @param {Optic} optic - model of the optic
-   * @param {Property.<representation>} representationProperty
+   * @param {Property.<Representation>} representationProperty
    * @param {Tandem} tandem
    */
   constructor( objectPositionProperty,

diff --git a/js/lens/model/Spotlight.js b/js/lens/model/Spotlight.js
@@ -46,6 +46,7 @@ class Spotlight {
 
     // determine the shape intersection of the screen and spotlight
     // @public (read-only) {Property.<Shape>}
+    // REVIEW: This is a bit vague, perhaps intersectionShapeProperty? At first I thought it was the shape of the spotlight source itself, and wondered why it was in the model.
     this.shapeProperty = new DerivedProperty( [
         screenPositionProperty,
         optic.positionProperty,