export string union values at definition

phetsims · Mar 4, 2022 · 89bb4d4 · 89bb4d4
1 parent 0e9a146
commit 89bb4d4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 14 deletions.
diff --git a/js/common/model/FocalLengthModelType.ts b/js/common/model/FocalLengthModelType.ts
@@ -7,7 +7,5 @@
  * @author Chris Malley (PixelZoom, Inc.)
  */
 
-const FocalLengthModelTypeValues = [ 'direct', 'indirect' ] as const;
-export type FocalLengthModelType = ( typeof FocalLengthModelTypeValues )[number];
-
-export { FocalLengthModelTypeValues };
+export const FocalLengthModelTypeValues = [ 'direct', 'indirect' ] as const;
+export type FocalLengthModelType = ( typeof FocalLengthModelTypeValues )[number];
diff --git a/js/common/model/OpticShape.ts b/js/common/model/OpticShape.ts
@@ -6,7 +6,5 @@
  * @author Chris Malley (PixelZoom, Inc.)
  */
 
-const OpticShapeValues = [ 'convex', 'concave', 'flat' ] as const;
-export type OpticShape = ( typeof OpticShapeValues )[number];
-
-export { OpticShapeValues };
+export const OpticShapeValues = [ 'convex', 'concave', 'flat' ] as const;
+export type OpticShape = ( typeof OpticShapeValues )[number];
diff --git a/js/common/model/OpticalImageType.ts b/js/common/model/OpticalImageType.ts
@@ -7,8 +7,6 @@
  * @author Chris Malley (PixelZoom, Inc.)
  */
 
-const OpticalImageTypeValues = [ 'real', 'virtual' ] as const;
+export const OpticalImageTypeValues = [ 'real', 'virtual' ] as const;
 export type OpticalImageType = ( typeof OpticalImageTypeValues )[number];
 
-export { OpticalImageTypeValues };
-
diff --git a/js/common/model/RaysType.ts b/js/common/model/RaysType.ts
@@ -6,8 +6,6 @@
  * @author Chris Malley (PixelZoom, Inc.)
  */
 
-const RaysTypeValues = [ 'marginal', 'principal', 'many', 'none' ] as const;
+export const RaysTypeValues = [ 'marginal', 'principal', 'many', 'none' ] as const;
 export type RaysType = ( typeof RaysTypeValues )[number];
 
-export { RaysTypeValues };
-