review comments, #154

phetsims · Aug 7, 2021 · 7181504 · 7181504
1 parent 0dd78e0
commit 7181504
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/js/common/view/OpticNode.js b/js/common/view/OpticNode.js
@@ -77,6 +77,7 @@ class OpticNode extends Node {
     } );
 
     // {Path} create the fill (or backing) path of the optic
+    // REVIEW: This is a very generic name, I'd recommend improving.
     const fillPath = new Path( modelViewTransform.modelToViewShape( optic.shapesProperty.value.fillShape ), {
       fill: options.fill
     } );

diff --git a/js/common/view/SourceObjectNode.js b/js/common/view/SourceObjectNode.js
@@ -225,7 +225,7 @@ class SourceObjectNode extends Node {
       stroke: SECOND_SOURCE_POINT_STROKE
     }, options );
 
-    return new Circle( options );
+    return new Circle( options ); // REVIEW: this takes a radius as the first arg
   }
 
   /**