Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should have proper formatting for bacterial nomenclature #44

Closed
phet-steele opened this issue Feb 22, 2017 · 6 comments
Closed

We should have proper formatting for bacterial nomenclature #44

phet-steele opened this issue Feb 22, 2017 · 6 comments
Assignees

Comments

@phet-steele
Copy link
Contributor

@aadish we should do one of two things for the "Real Cells" image caption. In either case, we should italicize E. coli AND make "coli" lowercase. I see the options we have being:

1). Italicize, lower case and stop there, results in: E. coli.
2). Italicize, lower case, and do not use the abbreviation, results in: Escherichia coli.

I believe option 2 is more proper since it's the first and only time in the sim we refer to the bacteria by name. However, I'm okay with option 1 if we do not have room for such a long string. @aadish, can you try to fit in option 2 first and we go from there?

For phetsims/tasks/issues/776.

@aadish
Copy link
Contributor

aadish commented Mar 10, 2017

@phet-steele I pushed changes to reflect option 2 take a look at master and let me know how does it look and any other changes required

@aadish aadish assigned aadish and phet-steele and unassigned aadish Mar 10, 2017
@phet-steele
Copy link
Contributor Author

@aadish Hooray we have room! Thanks! Two things to note:

  • We lost the period at the end of the first sentence, after (GFP).
  • Can we get rid of the space between the first and second lines? (Highlighted with the red box)

screen shot 2017-03-22 at 10 55 52 am

@phet-steele phet-steele assigned aadish and unassigned phet-steele Mar 22, 2017
aadish added a commit that referenced this issue Mar 29, 2017
@aadish
Copy link
Contributor

aadish commented Mar 29, 2017

@phet-steele pushed changes let me know how it looks now

@phet-steele
Copy link
Contributor Author

The latest still has a slight gap between the first and second lines. This may be a result of different font sizes being used in each line. @aadish is investigating. Here is the latest:
screen shot 2017-04-10 at 11 01 02 am

@aadish
Copy link
Contributor

aadish commented Apr 10, 2017

@phet-steele let me know how it looks just pushed the changes

@phet-steele
Copy link
Contributor Author

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants