Made Vector2 constructor arguments required, see phetsims/dot#85

phetsims · Feb 16, 2019 · 2ef5715 · 2ef5715
1 parent 496229f
commit 2ef5715
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/js/common/model/Ribosome.js b/js/common/model/Ribosome.js
@@ -187,7 +187,7 @@ define( function( require ) {
      * @public
      */
     getProteinAttachmentPoint: function( newAttachmentPoint ) {
-      newAttachmentPoint = newAttachmentPoint || new Vector2();
+      newAttachmentPoint = newAttachmentPoint || new Vector2( 0, 0 );
       newAttachmentPoint.x = this.getPosition().x + OFFSET_TO_PROTEIN_OUTPUT_CHANNEL.x;
       newAttachmentPoint.y = this.getPosition().y + OFFSET_TO_PROTEIN_OUTPUT_CHANNEL.y;
       return newAttachmentPoint;

diff --git a/js/common/model/ShapeChangingModelElement.js b/js/common/model/ShapeChangingModelElement.js
@@ -60,8 +60,8 @@ define( function( require ) {
     };
 
     // reusable position vectors, used to prevent allocations of new vectors and thus improve performance
-    this.reusablePositionVector1 = new Vector2();
-    this.reusablePositionVector2 = new Vector2();
+    this.reusablePositionVector1 = new Vector2( 0, 0 );
+    this.reusablePositionVector2 = new Vector2( 0, 0 );
   }
 
   geneExpressionEssentials.register( 'ShapeChangingModelElement', ShapeChangingModelElement );

diff --git a/js/common/model/attachment-state-machines/RibosomeAttachedState.js b/js/common/model/attachment-state-machines/RibosomeAttachedState.js
@@ -30,7 +30,7 @@ define( function( require ) {
   function RibosomeAttachedState( ribosomeAttachmentStateMachine ) {
     AttachmentState.call( this );
     this.ribosomeAttachmentStateMachine = ribosomeAttachmentStateMachine; //@public
-    this.proteinAttachmentPointScratchVector = new Vector2();
+    this.proteinAttachmentPointScratchVector = new Vector2( 0, 0 );
   }
 
   geneExpressionEssentials.register( 'RibosomeAttachedState', RibosomeAttachedState );

diff --git a/js/common/view/DnaMoleculeCanvasNode.js b/js/common/view/DnaMoleculeCanvasNode.js
@@ -35,8 +35,8 @@ define( function( require ) {
     this.backboneStrokeWidth = modelViewTransform.viewToModelDeltaX( backboneStrokeWidth ); // @private
 
     // @private - pre-allocated reusable vectors, used to reduce garbage collection
-    this.cp1ResuableVector = new Vector2();
-    this.cp2ResuableVector = new Vector2();
+    this.cp1ResuableVector = new Vector2( 0, 0 );
+    this.cp2ResuableVector = new Vector2( 0, 0 );
 
     // @private - four arrays for the DNA backbone representation
     var longerArrayLength = Util.roundSymmetric( this.model.strand1Segments.length / 2 );