Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create checkboxGroup for species checkboxes in histograms #254

Closed
arouinfar opened this issue Jun 5, 2024 · 2 comments
Closed

Create checkboxGroup for species checkboxes in histograms #254

arouinfar opened this issue Jun 5, 2024 · 2 comments

Comments

@arouinfar
Copy link
Contributor

For #30

The Speed and Kinetic Energy histograms have checkboxes to display the data for a single particle type.
image

I can see a client wanting to hide both checkboxes, but not just one. @Nancy-Salpepi and I think it would be nice to create a checkboxGroup that contains both heavyParticlesCheckbox and lightParticlesCheckbox. We could then feature checkboxGroup.visibleProperty and uninstrument the individual child checkbox.visibleProperty.

I recognize that request is treading into scope-creep territory, so feel free to veto @pixelzoom.

@pixelzoom
Copy link
Contributor

@arouinfar please review, close if OK.

@arouinfar
Copy link
Contributor Author

Thanks @pixelzoom, the changes look good on main. During revie, I noticed a possible dynamic layout bug and reported it in #258.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants