Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make heatCoolAmountProperty read-only on all screens #250

Closed
arouinfar opened this issue Jun 5, 2024 · 2 comments
Closed

Make heatCoolAmountProperty read-only on all screens #250

arouinfar opened this issue Jun 5, 2024 · 2 comments

Comments

@arouinfar
Copy link
Contributor

For #30

The heatCoolAmountProperty is read-only on the Ideal Screen, as the model needs to automatically heat/cool, depending on the Hold Contant mode. However, it is API-settable on the Explore and Energy screens. We made a design decision for the HeaterCoolerNode to snap-to-zero when not user-controlled, and we don't allow the snap-to-zero behavior to be turned off with a query parameter, as we do in EFAC and SoM. Allowing clients to control heatCoolAmountProperty is inconsistent with these decisions.

@pixelzoom please make heatCoolAmountProperty read-only on all screens.

@pixelzoom
Copy link
Contributor

heatCoolAmountProperty is now read-only for all screens. @arouinfar please review, close if OK.

@arouinfar
Copy link
Contributor Author

Thanks @pixelzoom. Looks good on main, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants