We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discovered during review for #30
@Nancy-Salpepi noticed that the Collision Counter is on by default, which differs from the published version the simulation.
Given that the Collision Counter isn't central to the primary learning goal (PV=NkT), let's keep it off by default.
The text was updated successfully, but these errors were encountered:
Collision Counter should be off by default, #249
fdfa8c2
This bug was introduced by @zepumph in 1b7cbcb, way back on 1/9/23, apparently for work that he was doing in chipper. Fixed in the above commits.
@Nancy-Salpepi please verify in main, close if OK.
Sorry, something went wrong.
Looks good in main. Closing.
Nancy-Salpepi
No branches or pull requests
Discovered during review for #30
@Nancy-Salpepi noticed that the Collision Counter is on by default, which differs from the published version the simulation.
Given that the Collision Counter isn't central to the primary learning goal (PV=NkT), let's keep it off by default.
The text was updated successfully, but these errors were encountered: