Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision Counter should be off by default #249

Closed
arouinfar opened this issue May 30, 2024 · 2 comments
Closed

Collision Counter should be off by default #249

arouinfar opened this issue May 30, 2024 · 2 comments

Comments

@arouinfar
Copy link
Contributor

arouinfar commented May 30, 2024

Discovered during review for #30

@Nancy-Salpepi noticed that the Collision Counter is on by default, which differs from the published version the simulation.

Given that the Collision Counter isn't central to the primary learning goal (PV=NkT), let's keep it off by default.

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 10, 2024

This bug was introduced by @zepumph in 1b7cbcb, way back on 1/9/23, apparently for work that he was doing in chipper. Fixed in the above commits.

@Nancy-Salpepi please verify in main, close if OK.

@Nancy-Salpepi
Copy link

Looks good in main. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants