Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODAP - Create wrapper prototypes #244

Closed
matthew-blackman opened this issue May 17, 2024 · 11 comments
Closed

CODAP - Create wrapper prototypes #244

matthew-blackman opened this issue May 17, 2024 · 11 comments

Comments

@matthew-blackman
Copy link
Contributor

matthew-blackman commented May 17, 2024

@kathy-phet asked for prototype wrappers to see how PhET-IO can be used in this sim to create an integration with CODAP. Let's create wrappers for the following:

  1. A wrapper in which the user presses a button to transfer the macroscopic variables (P, V, T, N) from the sim into CODAP. This should only apply to screens 1, 2, and 3.
  2. A wrapper in which the user selects the data they are interested in via checkboxes, and then presses a button to transfer the selected variables from the sim into CODAP.
  3. A wrapper for the Diffusion screen, in which the user presses a button to collect data for the center of mass positions of each species of gas, and a stopwatch value to record time elapsed.
@pixelzoom
Copy link
Contributor

pixelzoom commented May 20, 2024

Adding design meeting label, to clarify what the purpose and path forward is for these wrappers.

@pixelzoom
Copy link
Contributor

pixelzoom commented May 20, 2024

5/20/24 design meeting: @arouinfar @matthew-blackman @Nancy-Salpepi @kathy-phet @pixelzoom

  • @matthew-blackman was able to get 4 wrappers done in a couple of hours.
  • These wrappers are more than just an internal test. They are part of grant work.
  • PhET will work with CODAP on refining these wrappers.
  • It is on PhET's plate to figure out what to do with the wrappers longterm.
  • Wrappers are not tied to publication of GP 1.1.
  • No changes to GP PhET-iO have been identified so far.

Next steps:

@Nancy-Salpepi
Copy link

@matthew-blackman I started to make some graphs using the first wrapper. I noticed that "Connecting Lines" connects the data points in the order they were created rather than in the order from left to right along the x-axis.
Screenshot 2024-05-30 at 8 35 53 AM

@matthew-blackman
Copy link
Contributor Author

This appears to be a native CODAP feature. I'm seeing the same thing on the graphs in the CODAP example docs.

@pixelzoom
Copy link
Contributor

The wrappers look reasonable to me.

Is there a way to address what @Nancy-Salpepi reported in #244 (comment)? Can the data set be sorted by x-coordinate before asking CODAP to render it?

@pixelzoom pixelzoom removed their assignment Jun 11, 2024
@arouinfar
Copy link
Contributor

@matthew-blackman the wrappers all look good to me. Thanks for putting them together.

@arouinfar arouinfar removed their assignment Jun 14, 2024
@pixelzoom
Copy link
Contributor

@Nancy-Salpepi Do you have any additional feedback for @matthew-blackman?

@matthew-blackman Does what @Nancy-Salpepi reported in #244 (comment) need to be addressed? And what's next for this issue?

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Jun 20, 2024

Sorry I haven't gotten back to this issue, but I think it will be heading to QA for testing at some point. I can always add suggestions then (nothing that would affect the GP model). Is that OK @matthew-blackman @pixelzoom?

@matthew-blackman
Copy link
Contributor Author

@matthew-blackman Does what @Nancy-Salpepi reported in #244 (comment) need to be addressed? And what's next for this issue?

I don't believe anything needs to be done about the connecting lines representation. The data fluency learning goals deal only with best-fit lines/curves, which is a separate tool in CODAP. The design team has no stake in 'connect-the-dots' type of lines since they are not considered a valuable representation for the science or statistics learning goals being targeted.

It's also a native CODAP feature, so I don't think we could do anything even if we wanted to. If we really wanted to improve how the connecting lines look we could consider workarounds with caseIndex, but I think they would likely introduce other issues and unnecessary cost.

@matthew-blackman
Copy link
Contributor Author

matthew-blackman commented Jun 20, 2024

The wrapper prototypes are proof-of-concept that PhET-IO support is looking great for this sim. Nice work all! It was quick to set up and there are a lot of options for additional lessons. If/when they are published as part of the data fluency work, we should do another round to review/polish up the wrappers before publishing. This issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants