-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODAP - Create wrapper prototypes #244
Comments
Adding design meeting label, to clarify what the purpose and path forward is for these wrappers. |
5/20/24 design meeting: @arouinfar @matthew-blackman @Nancy-Salpepi @kathy-phet @pixelzoom
Next steps:
|
Gas Properties + CODAP wrappers are ready to review. Here are dev links for the four wrappers in development: Particle Data Wrapper: |
@matthew-blackman I started to make some graphs using the first wrapper. I noticed that "Connecting Lines" connects the data points in the order they were created rather than in the order from left to right along the x-axis. |
This appears to be a native CODAP feature. I'm seeing the same thing on the graphs in the CODAP example docs. |
The wrappers look reasonable to me. Is there a way to address what @Nancy-Salpepi reported in #244 (comment)? Can the data set be sorted by x-coordinate before asking CODAP to render it? |
@matthew-blackman the wrappers all look good to me. Thanks for putting them together. |
@Nancy-Salpepi Do you have any additional feedback for @matthew-blackman? @matthew-blackman Does what @Nancy-Salpepi reported in #244 (comment) need to be addressed? And what's next for this issue? |
Sorry I haven't gotten back to this issue, but I think it will be heading to QA for testing at some point. I can always add suggestions then (nothing that would affect the GP model). Is that OK @matthew-blackman @pixelzoom? |
I don't believe anything needs to be done about the connecting lines representation. The data fluency learning goals deal only with best-fit lines/curves, which is a separate tool in CODAP. The design team has no stake in 'connect-the-dots' type of lines since they are not considered a valuable representation for the science or statistics learning goals being targeted. It's also a native CODAP feature, so I don't think we could do anything even if we wanted to. If we really wanted to improve how the connecting lines look we could consider workarounds with caseIndex, but I think they would likely introduce other issues and unnecessary cost. |
The wrapper prototypes are proof-of-concept that PhET-IO support is looking great for this sim. Nice work all! It was quick to set up and there are a lot of options for additional lessons. If/when they are published as part of the data fluency work, we should do another round to review/polish up the wrappers before publishing. This issue can be closed. |
@kathy-phet asked for prototype wrappers to see how PhET-IO can be used in this sim to create an integration with CODAP. Let's create wrappers for the following:
The text was updated successfully, but these errors were encountered: