Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touchAreas for AccordionBox ExpandCollapseButtons #141

Closed
pixelzoom opened this issue Jul 6, 2019 · 4 comments
Closed

touchAreas for AccordionBox ExpandCollapseButtons #141

pixelzoom opened this issue Jul 6, 2019 · 4 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 6, 2019

@pixelzoom note: This comment from @jbphet was moved here from #111 (comment), since I think it warrants its own issue.

@jbphet said:

In regard to the checklist item "Are pointer areas optimized, especially for touch?", @arouinfar approved the pointer areas in #97, but I'm a bit skeptical because in the past I've been asked to expand the touch areas for the open/close buttons on accordion boxes. Here is what they look like for the current master version of "Gas Properties":

image

In "Build an Atom" the pointer areas for the accordion boxes look like this:
image

Perhaps the standards have changed for this, but I thought I'd point it out just in case.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 6, 2019

Wow, those are some extremely dilated buttons touchAreas for the ExpandCollapseButtons in "Build An Atom". I've never been asked to do anything like that. And my understanding is that the "standard" is the default in AccordionBox. If it's not, shouldn't it be? Why should every client have to change the default?

That said... @arouinfar Your call on this.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 6, 2019

If we apply the same touchArea proportions used in BAA to Gas Properties, that would be touchAreaXDilation: 15 and touchAreaYDilation: 15. There will be problems with overlap, for example:

screenshot_1273

If you want to dilate a bit more than the default, then I recommend touchAreaXDilation:6 and touchAreaYDilation:6. For example:

screenshot_1272

@pixelzoom
Copy link
Contributor Author

I said:

If you want to dilate a bit more than the default, then I recommend touchAreaXDilation:6 and touchAreaYDilation:6. For example: ...

Since I made this code change to generate the above screenshot, I took a chance that this would be OK and committed it. @arouinfar please have a look at master, let me know if you want this reverted or changed.

@arouinfar
Copy link
Contributor

The extremely dilated touch areas in BAA stemmed from phetsims/qa#295. At the time, AccordionBox titles were not interactive (see phetsims/sun#502). Since the titles are now again interactive, I don't see a need to greatly dilate the touch areas of the ExpandCollapseButton, but a dilation of 6 looks good to me.

@arouinfar arouinfar assigned pixelzoom and unassigned arouinfar Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants