Skip to content

Commit

Permalink
Rename Separators to Deprecated and Dividers to Separators, see: phet…
Browse files Browse the repository at this point in the history
  • Loading branch information
marlitas committed Sep 13, 2022
1 parent 0e6e96e commit bd3f465
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion doc/implementation-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ In addition to this document, you are encouraged to read:
This section defines terminology that you'll see used throughout the internal and external documentation. Skim this section once, and refer back to it as you explore the implementation.

Much of the terminology for this sim is identified by labels that are visible in the user interface (Stopwatch,
Collision Detector, Particle Flow Rate, Divider, ...) and those terms are not included here.
Collision Detector, Particle Flow Rate, Separator, ...) and those terms are not included here.

Here's the (relatively short) list of terms that might be unclear:

Expand Down
4 changes: 2 additions & 2 deletions js/diffusion/view/DataAccordionBox.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import merge from '../../../../phet-core/js/merge.js';
import ModelViewTransform2 from '../../../../phetcommon/js/view/ModelViewTransform2.js';
import { HBox, Text } from '../../../../scenery/js/imports.js';
import AccordionBox from '../../../../sun/js/AccordionBox.js';
import VSeparator from '../../../../sun/js/VSeparator.js';
import VSeparatorDeprecated from '../../../../sun/js/VSeparatorDeprecated.js';
import Tandem from '../../../../tandem/js/Tandem.js';
import GasPropertiesColors from '../../common/GasPropertiesColors.js';
import GasPropertiesConstants from '../../common/GasPropertiesConstants.js';
Expand Down Expand Up @@ -57,7 +57,7 @@ class DataAccordionBox extends AccordionBox {
const rightDataNode = new DiffusionDataNode( rightData, modelViewTransform );

// Vertical separator, analogous to the container's divider
const separator = new VSeparator( 75, {
const separator = new VSeparatorDeprecated( 75, {
lineWidth: 2,
stroke: GasPropertiesColors.dividerColorProperty
} );
Expand Down
6 changes: 3 additions & 3 deletions js/diffusion/view/DiffusionControlPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import BooleanProperty from '../../../../axon/js/BooleanProperty.js';
import ReadOnlyProperty from '../../../../axon/js/ReadOnlyProperty.js';
import merge from '../../../../phet-core/js/merge.js';
import { VBox } from '../../../../scenery/js/imports.js';
import HSeparator from '../../../../sun/js/HSeparator.js';
import HSeparatorDeprecated from '../../../../sun/js/HSeparatorDeprecated.js';
import Panel from '../../../../sun/js/Panel.js';
import Tandem from '../../../../tandem/js/Tandem.js';
import GasPropertiesColors from '../../common/GasPropertiesColors.js';
Expand Down Expand Up @@ -81,13 +81,13 @@ class DiffusionControlPanel extends Panel {
tandem: options.tandem.createTandem( 'settingsNode' )
} ),

// Remove/Reset Divider button, centered
// Remove/Reset Separator button, centered
new FixedWidthNode( contentWidth, dividerToggleButton, {
align: 'center'
} ),

// ------------
new HSeparator( contentWidth, {
new HSeparatorDeprecated( contentWidth, {
stroke: GasPropertiesColors.separatorColorProperty,
maxWidth: contentWidth
} ),
Expand Down
4 changes: 2 additions & 2 deletions js/ideal/view/IdealControlPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import NumberProperty from '../../../../axon/js/NumberProperty.js';
import ReadOnlyProperty from '../../../../axon/js/ReadOnlyProperty.js';
import merge from '../../../../phet-core/js/merge.js';
import { VBox } from '../../../../scenery/js/imports.js';
import HSeparator from '../../../../sun/js/HSeparator.js';
import HSeparatorDeprecated from '../../../../sun/js/HSeparatorDeprecated.js';
import Panel from '../../../../sun/js/Panel.js';
import Tandem from '../../../../tandem/js/Tandem.js';
import GasPropertiesColors from '../../common/GasPropertiesColors.js';
Expand Down Expand Up @@ -73,7 +73,7 @@ class IdealControlPanel extends Panel {
maxWidth: contentWidth,
tandem: options.tandem.createTandem( 'holdConstantControl' )
} ) );
children.push( new HSeparator( contentWidth, {
children.push( new HSeparatorDeprecated( contentWidth, {
stroke: GasPropertiesColors.separatorColorProperty,
maxWidth: contentWidth
} ) );
Expand Down

0 comments on commit bd3f465

Please sign in to comment.