Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad LICENSE in several sims #69

Closed
samreid opened this issue Feb 13, 2018 · 3 comments
Closed

Bad LICENSE in several sims #69

samreid opened this issue Feb 13, 2018 · 3 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Feb 13, 2018

image

build-an-atom referenced in wrong sims. Discovered in #64

@samreid samreid self-assigned this Feb 13, 2018
@samreid
Copy link
Member Author

samreid commented Feb 14, 2018

It looks like the majority of the LICENSE files were committed by @jbphet, reassigning it to @jbphet so he knows its a problem and to address it. I think we just use the GPL v3 template (without filling in the project name).

@samreid samreid assigned jbphet and unassigned samreid Feb 14, 2018
@jbphet
Copy link
Contributor

jbphet commented Feb 14, 2018

Yes, it appears that the template portion was filled in for these files. The line in question should look like this:

{project}  Copyright (C) {year}  {fullname}

jbphet added a commit to phetsims/build-an-atom that referenced this issue Feb 14, 2018
jbphet added a commit to phetsims/balancing-act that referenced this issue Feb 14, 2018
jbphet added a commit to phetsims/area-builder that referenced this issue Feb 14, 2018
jbphet added a commit to phetsims/faradays-law that referenced this issue Feb 14, 2018
jbphet added a commit to phetsims/arithmetic that referenced this issue Feb 14, 2018
jbphet added a commit to phetsims/estimation that referenced this issue Feb 14, 2018
@jbphet
Copy link
Contributor

jbphet commented Feb 16, 2018

Should be fixed, closing. @samreid - feel free to take a look if you'd like to double check, and re-open if necessary.

@jbphet jbphet closed this as completed Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants