appending a non-existent locale to standard wrapper does not load

[arouinfar]

Related to phetsims/qa#899

The problem described in https://github.com/phetsims/phet-io/issues/1901 exists in the latest Friction RC.

This has already been corrected in master, but it's not obvious to me which commits need cherry-picking, so I recommend that @jessegreenberg consult with @samreid.

Additionally, I made a related change to phet-io-guide.md that will also need to be cherry-picked.
https://github.com/phetsims/phet-io-sim-specific/commit/b3b518e231cfa737aa5e51b6533647c2f3f7ca11

[jessegreenberg]

Thanks @arouinfar. At first I thought this was #334, but that was about non-existent locales in studio. This is a different problem for the standard wrapper.

[jessegreenberg]

https://github.com/phetsims/phet-io-wrappers/commit/84da4632b21a7163b3e7922604d2ced29b5d4133 is the only commit referenced in https://github.com/phetsims/phet-io/issues/1901, @samreid is that all we need?

Then Ill also do https://github.com/phetsims/phet-io-sim-specific/commit/b3b518e231cfa737aa5e51b6533647c2f3f7ca11.

[jessegreenberg]

I think that phetsims/ph-scale#274 lists what needs to be cherry-picked for this.

[jessegreenberg]

phetsims/ph-scale#274 (comment) and the following comments confirm that those two commits are all that are needed.

[jessegreenberg]

I had a merge conflict with https://github.com/phetsims/phet-io-sim-specific/commit/b3b518e231cfa737aa5e51b6533647c2f3f7ca11. I met with @arouinfar and she helped me resolve conflicts the best way for friction-1.6.

@arouinfar said to test passing ?locale=xy with and without ?phetioDebug=true for the standard wrapper after these changes are cherry-picked.

[jessegreenberg]

While testing locally I kept hitting an assertion running studio from compiled index about the namespace. @samreid identified that I needed phetsims/phet-core@ee0545a, Ill cherry-pick that into friction-1.6 SHAs as well.

[jessegreenberg]

OK, I verified in 1.6 SHAs that ?locale=xy in the standard wrapper does not cause any error or assertion. That is true even when running with ?phetioDebug=true, which matches the behavior described in phetsims/ph-scale#274 (comment).

Ready to verify. @arouinfar if you wouldn't mind verifying this one in rc.3, that would probably be best.

[arouinfar]

@jessegreenberg looks good in rc.3, but I'll leave it for QA to close during testing.

[pixelzoom]

... 3, but I'll leave it for QA to close during testing.

Then I'll changed the label to fixed-awaiting-deploy.

[Nancy-Salpepi]

This is fixed in rc.3. When adding a nonexistent locale, such as xy, to the standard wrapper's url, it is ignored and the sim opens in English. With ?phetioDebug=true, there is no assertion error and the sim opens in English.
The client guide has also been updated:

If you specify a locale for which a translation does not exist, the locale query parameter is ignored and the simulation will retain the localeProperty used when creating the Standard PhET-iO Wrapper.

Closing.