Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voicing reads Arrows in wrong order in dialog #337

Closed
Tracked by #899
Nancy-Salpepi opened this issue Feb 3, 2023 · 4 comments
Closed
Tracked by #899

Voicing reads Arrows in wrong order in dialog #337

Nancy-Salpepi opened this issue Feb 3, 2023 · 4 comments

Comments

@Nancy-Salpepi
Copy link

Test device
Mac

Operating System
10.15.7 and 13.1

Browser
safari/chrome

Problem description
For phetsims/qa#886, this is minor: In the keyboard shortcuts dialog, Voicing reads the arrows in the wrong order. The arrows look like this:
Screenshot 2023-02-03 at 8 02 10 AM

but Voicing reads them as "Up. Left. Down. Right.

This also happens in Quadrilateral.

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Friction‬ URL: https://phet-dev.colorado.edu/html/friction/1.6.0-rc.1/phet/friction_all_phet.html Version: 1.6.0-rc.1 2023-01-17 16:32:22 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36 Language: en-US Window: 1600x781 Pixel Ratio: 1.7999999523162842/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@jessegreenberg
Copy link
Contributor

@terracoda and I reviewed this and found that the icons were accidentally reordered in c5be548ed9fd3dae61381331f9aa63fd68352e1e, I will , Ill change the order in scenery-phet.

jessegreenberg added a commit to phetsims/scenery-phet that referenced this issue Feb 3, 2023
@jessegreenberg
Copy link
Contributor

OK, reverted the order to what it once was. @terracoda said that this order was important because it matches the movement of the WASD keys. Great catch @Nancy-Salpepi!

image

@jessegreenberg
Copy link
Contributor

cherry-picked, ready to verify.

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 9, 2023

Looks good in rc.3

@KatieWoe KatieWoe closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants