-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voicing reads Arrows in wrong order in dialog #337
Comments
@terracoda and I reviewed this and found that the icons were accidentally reordered in c5be548ed9fd3dae61381331f9aa63fd68352e1e, I will , Ill change the order in scenery-phet. |
jessegreenberg
added a commit
to phetsims/scenery-phet
that referenced
this issue
Feb 3, 2023
OK, reverted the order to what it once was. @terracoda said that this order was important because it matches the movement of the WASD keys. Great catch @Nancy-Salpepi! |
jessegreenberg
added a commit
to phetsims/scenery-phet
that referenced
this issue
Feb 7, 2023
jessegreenberg
added
status:ready-for-review
and removed
status:ready-to-cherry-pick
labels
Feb 7, 2023
cherry-picked, ready to verify. |
27 tasks
Looks good in rc.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test device
Mac
Operating System
10.15.7 and 13.1
Browser
safari/chrome
Problem description
For phetsims/qa#886, this is minor: In the keyboard shortcuts dialog, Voicing reads the arrows in the wrong order. The arrows look like this:
but Voicing reads them as "Up. Left. Down. Right.
This also happens in Quadrilateral.
The text was updated successfully, but these errors were encountered: