Moving book with WASD in fullscreen causes Mac "funk" noise

[ghost]

Test Device

Dirac

Operating System

macOS 10.10.5
macOS 10.11.6

Browser

Safari

Problem Description

For phetsims/qa#244. In fullscreen, if the book is moved with WASD, the Mac "funk" noise is heard.

Funk Noise: https://www.youtube.com/watch?v=8rz44o_gGpE

[jessegreenberg]

@lmulhall-phet @KatieWoe do you know if this has ever happened in BASE? For instance, does it happen with https://phet.colorado.edu/sims/html/balloons-and-static-electricity/latest/balloons-and-static-electricity_en.html?phetioValidateTandems in full screen mode?

[KatieWoe]

Does happen on BASE in master @jessegreenberg

[jessegreenberg]

OK thanks @KatieWoe.

[KatieWoe]

Also note, since I was a bit confused, it doesn't stop movement. It moves normally but also plays the sound.

[jessegreenberg]

I see. Does this also happen in the deployed version of BASE?

[KatieWoe]

Seems to yes

[jessegreenberg]

OK, that is helpful, thanks.

[zepumph]

We pushed a potential fix to master, @KatieWoe will you see if master is fixed please?

[KatieWoe]

Seems fixed on master @zepumph
I checked on a 10.13.6 device, but the issue was present in the rc on this platform as well.

[zepumph]

Thanks for checking! I have not yet cherry-picked this into master, but will do so to the branch soon.

[zepumph]

Commit has been cherry-picked into branch (note to self)

[KatieWoe]

1.5.0-rc.2 looks good

[JRomero0613]

I have been testing on 1.5.0-rc.2 on Safari on MacOS 10.12.6 and have seen this issue occur. This occurs when the book has been navigated to using tab, but has not been picked up using space. The outline around the book should be a solid pink line to get the "funk" noise to occur. If the book has been picked up the noise will not occur.

[KatieWoe]

Since you can't move the book until it has been picked up, this may be intended. @zepumph?

[KatieWoe]

phetsims/qa#276

[zepumph]

Since you can't move the book until it has been picked up, this may be intended. @zepumph?

I agree. Arrow keys should not do anything in the sim when the book has not been grabbed. Since the "solid red lined" book is basically the same type of button as highlighting the reset all button, I would think this behavior is expected. I'm ready to close this if that seems alright to @JRomero0613.

[KatieWoe]

One last note. The sound does only play when in full screen. Not sure if that says anything.

[zepumph]

Sounds fine to @jessegreenberg and I, @JRomero0613 please close once you have reviewed this.

[zepumph]

I'm going to close this. @JRomero0613 let me know if you have any other questions.