fix issue where dragging books with keyboard interaction was causing …

…infinite output levels, see #148
phetsims · Dec 5, 2018 · 95dcb99 · 95dcb99
1 parent 424ca9b
commit 95dcb99
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/js/friction/view/BookRubSoundGenerator.js b/js/friction/view/BookRubSoundGenerator.js
@@ -84,7 +84,7 @@ define( function( require ) {
         if ( contact && Math.abs( topBookXVelocity ) > 0 && !rubSoundLockedOut ) {
 
           // set the output level based on the velocity of the book
-          let noiseAmplitude = options.maxOutputLevel * Math.pow( Math.abs( topBookXVelocity ), 0.25 );
+          let noiseAmplitude = options.maxOutputLevel * Math.min( Math.pow( Math.abs( topBookXVelocity ), 0.25 ), 1 );
           this.setOutputLevel( noiseAmplitude, 0.05 );
         }
         else {

diff --git a/js/friction/view/FrictionScreenView.js b/js/friction/view/FrictionScreenView.js
@@ -108,7 +108,7 @@ define( function( require ) {
     // @private {BookRubSoundGenerator} - sound generator for when the books rub together
     // TODO: Ashton - review and modify level if needed
     this.bookRubSoundGenerator = new BookRubSoundGenerator( model.topBookPositionProperty, model.contactProperty, {
-      maxOutputLevel: 0.2
+      maxOutputLevel: 0.5
     } );
     soundManager.addSoundGenerator( this.bookRubSoundGenerator );