Added TODOs, see #64

phetsims · Feb 6, 2018 · 58adf4f · 58adf4f
1 parent cdd5dbd
commit 58adf4f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/js/friction/view/FrictionScreenView.js b/js/friction/view/FrictionScreenView.js
@@ -93,8 +93,14 @@ define( function( require ) {
   friction.register( 'FrictionScreenView', FrictionScreenView );
 
   return inherit( ScreenView, FrictionScreenView, {
-    step: function( timeElapsed ) {
-      this.magnifierNode.step( timeElapsed );
+
+    /**
+     * Move forward in time
+     * @param {number} dt - seconds
+     * @public
+     */
+    step: function( dt ) {
+      this.magnifierNode.step( dt );
     }
   } );
 } );
diff --git a/js/friction/view/magnifier/AtomNode.js b/js/friction/view/magnifier/AtomNode.js
@@ -110,6 +110,9 @@ define( function( require ) {
           self.setVisible( false );
         }
       };
+
+      // TODO: why is this linking every time it evaporates?  Can it only evaporate once?
+      // TODO: does this file need a dispose function?
       this.model.newStepProperty.link( self.handler );
     },
     getYrange: function() {

diff --git a/js/friction/view/magnifier/MagnifierNode.js b/js/friction/view/magnifier/MagnifierNode.js
@@ -272,6 +272,11 @@ define( function( require ) {
 
   return inherit( Node, MagnifierNode, {
 
+    /**
+     * Move forward in time
+     * @param {number} dt - seconds
+     * @public
+     */
     step: function( dt ) {
       this.atomCanvasNode.invalidatePaint(); // tell the atom canvas to redraw itself
     },