Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't drag empty fractions by line #79

Closed
KatieWoe opened this issue Jan 18, 2019 · 4 comments
Closed

Can't drag empty fractions by line #79

KatieWoe opened this issue Jan 18, 2019 · 4 comments
Assignees
Labels
priority:3-medium type:bug Something isn't working

Comments

@KatieWoe
Copy link

Test device:
Dell
Operating System:
Win 10
Browser:
chrome
Problem description:
For phetsims/qa#261, phetsims/qa#262, and phetsims/qa#259
It is not possible to drag the number fraction builders by their line, either with mouse or touch. Anywhere else within the pointer area will work. Likely a minor issue.
Steps to reproduce:

  1. Go to either the lab screen or a game level in which you build a number fraction
  2. Try to drag either type of the number fraction builder by the fraction line
  3. Try to drag either type of the number fraction builder by any other part

Screenshots:
cantdragmiddleline

Troubleshooting information (do not edit):

Name: ‪Fractions: Intro‬
URL: https://phet-dev.colorado.edu/html/fractions-intro/1.0.0-rc.1/phet/fractions-intro_en_phet.html?showPointerAreas
Version: 1.0.0-rc.1 2019-01-16 21:29:50 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36
Language: en-US
Window: 1536x732
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {}

@KatieWoe KatieWoe added the type:bug Something isn't working label Jan 18, 2019
@ariel-phet ariel-phet removed their assignment Jan 21, 2019
@ariel-phet
Copy link

@jonathanolson seems worthy of fixing for a better UX if easy to do.

jonathanolson added a commit to phetsims/build-a-fraction that referenced this issue Jan 22, 2019
jonathanolson added a commit to phetsims/fractions-equality that referenced this issue Jan 22, 2019
jonathanolson added a commit to phetsims/fractions-intro that referenced this issue Jan 22, 2019
jonathanolson added a commit to phetsims/fractions-mixed-numbers that referenced this issue Jan 22, 2019
@jonathanolson
Copy link
Contributor

jonathanolson commented Jan 22, 2019

Patched in master and on the release branches. @KatieWoe can you verify? (Everywhere in the mouse/touch area should now work to drag it, the gaps between rectangles were also problematic before)

@KatieWoe
Copy link
Author

@jonathanolson Confirmed on master (tested on Build a Fraction Lab screen)

@KatieWoe
Copy link
Author

1.0.0-rc.2 looks clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:3-medium type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants