Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove smiley and Next button when returning to a completed level #46

Closed
phet-steele opened this issue Jan 4, 2019 · 5 comments
Closed
Assignees

Comments

@phet-steele
Copy link

The games in FMN, FI, and BAF have a small deviation from Expression Exchange's game (the sim with PhET's most clever game design). ExEx would not have a smiley face or Next button at all when returning to completed levels, yet the games in these fractions sims do. I'd have to imagine this was done in ExEx to motivate a player to refresh a level and keep playing.

Thoughts @ariel-phet? For phetsims/qa/issues/250.

@amanda-phet
Copy link

We weren't trying to exactly mimic Expression Exchange, so this discrepancy is not a concern.

With that said, I would be fine if the smiley face and next button are not visible. @ariel-phet what do you think?

@phet-steele
Copy link
Author

I realize I totally need to clarify that ExEx only hides the smiley and Next button on a completed level AFTER all levels have been completed.

@ariel-phet
Copy link

@jonathanolson if possible we should keep consistent with ExEx here. So it sounds like no "next" or "smiley face" will be shown after all levels are completed.

IMO this would refer to all Shape levels or all Number levels independently. So if you complete all shape levels the smiley and next would not appear (to encourage refreshing and further game) play, but the number levels (if all had not been completed for example) would still show these buttons as you completed levels.

@jonathanolson
Copy link
Contributor

This was implemented above, can you verify?

@phet-steele
Copy link
Author

Lookin' good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants