-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show overlay with "left value in the back" and dotted line if completely obscured #8
Comments
@krhensberry said: Yes, left value in back. Let's try with the dotted line also and see how it feels as we move things around. |
I added a dotted line for a completely obscured "left" value. It's ready for me to post a dev version for review. |
Also, the edges of the dotted line should line up with the edges of the shape. Right now they go outside of it which makes it seem like the borders of the green shape are bigger than the borders of the blue shape. |
I agree the stroke is much too thick--but we'll have to fine tune the colors of each representation to make sure the dotted line is visible. @krhensberry do you want to help me choose colors and stroke parameters or should I work with @gruneich ? |
I mentioned this in another ticket, but I would start with the colors we have in the mockup (a light blue and pink/magenta color). I also iterated with @gruneich a couple of times in the mockup to try and make the stroke thickness something we were happy with. We'll have to test this on a tablet to make sure that thickness works, but you should start with what we have in the mockup. |
…s overlap, and switched to blue/magenta, see #8
Fixes in the commit above, ready for me to post a version for review. |
This looks good to me for now. I haven't tested it on a tablet though. @gruneich can you see how it looks on the smaller screen? |
I tried on an iPad mini and it looked good to me. |
How did we decide to show the overlay of both? Is it "larger value
in back"? I believe Karina was advocating for showing "left value in
back" and dotted line if it is completely behind but I recall others had
other suggestions and I can't recall if/what we decided.
The text was updated successfully, but these errors were encountered: