Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should time controls be disabled when there is no possibility of animation? #26

Closed
pixelzoom opened this issue Dec 12, 2020 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Dec 12, 2020

Should the time control be disabled when the domain is not set to "space & time"? There is no animation occurring otherwise.

The concern is that the user might play with the time control when domain is "space" or "time", see that it does nothing with those settings, leave the sim paused, and never set it to play for "space & time". If the control is disabled, then the first time they select "space & time", they will see animation.

In the Java version, the control is always enabled.

@pixelzoom pixelzoom changed the title should time control be disabled when there is no possibility of animation? Should time controls be disabled when there is no possibility of animation? Dec 12, 2020
@pixelzoom
Copy link
Contributor Author

I went ahead and enabled the time controls only for "space & time". Test-drive in master.

@arouinfar
Copy link
Contributor

I think it's very weird to have an enabled TimeControlNode when it doesn't actually do anything. The behavior in master looks natural to me, thanks @pixelzoom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants