Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code polishes #176

Closed
6 tasks done
pixelzoom opened this issue Sep 21, 2021 · 1 comment
Closed
6 tasks done

Code polishes #176

pixelzoom opened this issue Sep 21, 2021 · 1 comment
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Sep 21, 2021

For #165 code review, @jonathanolson and I discussed a couple of other potential polishes:

  • More liberal use of type expressions for local vars (reduce code searches)
  • Type expressions for this.fields defined at end of constructor (reduce code searches)
  • Review calls to Property setDeferred
  • Replace _.filter with built-in
  • Replace _.map with built-in
  • Replace for loops with map or forEach
@pixelzoom pixelzoom self-assigned this Sep 21, 2021
pixelzoom added a commit that referenced this issue Sep 21, 2021
pixelzoom added a commit that referenced this issue Sep 21, 2021
pixelzoom added a commit that referenced this issue Sep 21, 2021
pixelzoom added a commit that referenced this issue Sep 21, 2021
pixelzoom added a commit that referenced this issue Sep 21, 2021
pixelzoom added a commit that referenced this issue Sep 21, 2021
@pixelzoom
Copy link
Contributor Author

Done, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant