Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ?rewardScore public #143

Closed
pixelzoom opened this issue Aug 16, 2021 · 2 comments
Closed

Make ?rewardScore public #143

pixelzoom opened this issue Aug 16, 2021 · 2 comments
Assignees
@arouinfar
Labels
status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

From #4 (comment):

Change the condition for triggering the RewardNode (e.g. lower the threshold to 5 stars)

... so make the rewardScore query parameter public.
@pixelzoom pixelzoom self-assigned this Aug 16, 2021
pixelzoom added a commit that referenced this issue Aug 16, 2021
@pixelzoom
make ?rewardScore public, #143
1fc42ec
@pixelzoom
Copy link
Contributor Author

Done in the above commit. rewardScore must be an integer > 0. If it's not, you'll see an OopsDialog like the example below. @arouinfar please verify in master.

screenshot_1188

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Aug 16, 2021
@arouinfar
Copy link
Contributor

Looks good in master, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @arouinfar