Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model.md #126

Closed
pixelzoom opened this issue Aug 12, 2021 · 2 comments
Closed

model.md #126

pixelzoom opened this issue Aug 12, 2021 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Aug 12, 2021

Complete the model description in model.md, then have @arouinfar review it.

Unfortunately, there's nothing from the Java version to be reused here.

@pixelzoom pixelzoom self-assigned this Aug 12, 2021
pixelzoom added a commit that referenced this issue Aug 27, 2021
pixelzoom added a commit that referenced this issue Aug 27, 2021
pixelzoom added a commit that referenced this issue Aug 27, 2021
pixelzoom added a commit that referenced this issue Aug 27, 2021
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Aug 27, 2021

@arouinfar this is ready for review. Let me know if you'd like to change anything. Feel free to correct any typos. There's no hurry on reviewing this. It's good enough for the code reviewer, and can easily be changed at any point during QA.

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Aug 27, 2021
pixelzoom added a commit that referenced this issue Aug 27, 2021
This was referenced Aug 27, 2021
arouinfar added a commit that referenced this issue Sep 21, 2021
@arouinfar
Copy link
Contributor

@pixelzoom this looks really good. I fixed a few typos, but I don't have any other comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants