Skip to content

Commit

Permalink
fix non-existent font option for SumSymbolNode, #165
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Sep 20, 2021
1 parent 030c8a3 commit 0578974
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion js/common/view/SumSymbolNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class SumSymbolNode extends Node {
// SumSymbolNode options
integration: false, // true=integration, false=summation
fontSize: 30,
indexFontSize: 12
indexFontSize: 15
}, options );

// The symbol for the type of sum.
Expand Down
4 changes: 1 addition & 3 deletions js/discrete/view/DiscreteSumEquationNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,7 @@ class DiscreteSumEquationNode extends Node {
} );

// Capital sigma, summation symbol
const summationNode = new SumSymbolNode( n, 1, numberOfHarmonicsProperty, {
font: options.font //REVIEW: I don't see a `font` option in SumSymbolNode, should we be pulling out fontSize?
} );
const summationNode = new SumSymbolNode( n, 1, numberOfHarmonicsProperty );

// Everything to the right of the summation symbol, set in multilink below
const rightNode = new RichText( '', {
Expand Down
2 changes: 0 additions & 2 deletions js/wavepacket/view/WavePacketSumEquationNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ class WavePacketSumEquationNode extends Node {

// Capital sigma, summation symbol
const sumSymbolNode = new SumSymbolNode( FMWSymbols.n, -Infinity, new NumberProperty( Infinity ), {
//REVIEW: No `font` option in SumSymbolNode that I can find
font: options.font,
indexFontSize: 15
} );

Expand Down

0 comments on commit 0578974

Please sign in to comment.