Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for water tower, and flow screens #161

Open
kmsravindra opened this issue Sep 2, 2014 · 21 comments
Open

Icons for water tower, and flow screens #161

kmsravindra opened this issue Sep 2, 2014 · 21 comments

Comments

@kmsravindra
Copy link

Could we get the icons for water tower, flow and under pressure screen

@samreid
Copy link
Member

samreid commented Sep 2, 2014

@ariel-phet, I asked @kmsravindra to create this issue and assign it to you. Not sure who you want to design/create this artwork but let us know when it's ready. So we actually need 6 icons: the icons for home screen and icons for navbar (if they differ).

@ariel-phet
Copy link

@samreid It looks like Bryce already made some icons that look pretty reasonable. it also seems they could be drawn in code fairly easily. Does your copy of the mockup you sent to actualconcepts have these icons depicted?

@ariel-phet ariel-phet assigned samreid and ariel-phet and unassigned ariel-phet and samreid Sep 3, 2014
@ariel-phet
Copy link

I will get these icons created, but somewhat low priority since they do not need to be finished until the project is wrapping up (including Under Pressure)

@ariel-phet ariel-phet assigned samreid and unassigned ariel-phet Oct 15, 2014
@ariel-phet
Copy link

@amanda-phet created some nice icons, and should be emailing them to @samreid for inclusion in the sim

@samreid
Copy link
Member

samreid commented Oct 22, 2014

I have received the artwork from @amanda-phet and it looks good, but one of the files is nearly 8 MB and another is nearly 4MB. I discussed this with the other developers and we decided this is too big to put into GitHub. I wasn't sure whether to ask @amanda-phet if she can produce something that looks similar but has <1MB each or whether I should draw them in code.

@amanda-phet
Copy link

I can always make an image smaller (and thus lower quality).

On Oct 22, 2014, at 10:12 AM, Sam Reid <[email protected]mailto:[email protected]> wrote:

I have received the artwork from @amanda-phethttps://github.com/amanda-phet and it looks good, but one of the files is nearly 8 MB and another is nearly 4MB. I discussed this with the other developers and we decided this is too big to put into GitHub. I wasn't sure whether to ask @amanda-phethttps://github.com/amanda-phet if she can produce something that looks similar but has <1MB each or whether I should draw them in code.


Reply to this email directly or view it on GitHubhttps://github.com//issues/161#issuecomment-60110769.

@samreid
Copy link
Member

samreid commented Oct 23, 2014

The issue is the size of the AI file, which should also be kept under version control. The raster image sizes are not a problem.

@samreid
Copy link
Member

samreid commented Oct 24, 2014

@ariel-phet said:

Ah...this is likely due to the fact that the faucet contains components
that were drawn using the 3-d features of Illustrator.

After Mike Fowler finishes his work on the arithmetic icons, his next
project is redrawing the faucet assets in 2-d which should greatly
reduce this file size overhead in illustrator.

There is a fair amount of work left to be done on FPAF even once AC
finishes (since there are a list of change requests) so no big rush,
thanks for the update.

@samreid samreid removed their assignment Mar 11, 2015
@zepumph
Copy link
Member

zepumph commented Sep 22, 2017

@ariel-phet it may be good to get this issue going again.

  • I see that we still have the 8MB file checked into github, not sure if that is still a problem. Is it?

  • For the screen icons, I think we will eventually have screenshots, but currently we are just using mockups. I don't think we are ready to get rid of these yet, but maybe soon.

@zepumph zepumph changed the title Icons for water tower, flow and under pressure screen Icons for water tower, and flow screens Sep 22, 2017
@zepumph
Copy link
Member

zepumph commented Sep 22, 2017

Renaming the issue since under-pressure already has a formal icon, not a mockup.

This was referenced Sep 22, 2017
@ariel-phet
Copy link

@zepumph yes the 8 MB file should probably be reduced/replaced

@arouinfar might be good to start thinking about icons here. I think our "icon game" has progressed quite a bit since this sim

@amanda-phet
Copy link

@arouinfar I will email you the icons I created three years ago. I suspect the reason the files were large is because the artwork was created using 3D revolve (from Bryce's sim artwork), so if you can replace the water faucet with the new artwork that uses gradients, and redraw the copper-colored pipe using gradients, the file size will surely be smaller. And of course, if you're making the icons, feel free to change the design however you would like.

@arouinfar
Copy link

Got it, thanks @amanda-phet! I should be able to replace most things with 2D artwork. The faucet head will be more of a challenge, but I will try replacing it with a .png to see how it affects the file size/quality. Another option would be to ask Cheryl to redraw the faucet head in 2D.

@arouinfar
Copy link

@amanda-phet mentioned that we already have a 2D asset for the faucet, and according to #161 (comment), it looks like Mike Fowler may have been the one to create it. I haven't been able to locate the asset on Drive, and the none sims that use the faucet (Concentration, Beer's Law Lab, pH Scale, pH Scale: Basics, and Under Pressure) have the asset checked in on GitHub. Perhaps it's been drawn in code? If so, perhaps the screen icons can be something that are entirely drawn in code (from reference mockups). In the meantime, I'll work on updating the icons using the 3D faucet.

@arouinfar
Copy link

Tracked down the faucetNode component in scenery-phet.

@arouinfar
Copy link

Last update for now -- @amanda-phet found the .ai file for the 2D faucet, and it's now been added to the common components .ai file. I'll use the 2D version when mocking things up, and we can decide later whether or not the icons should ultimately be drawn in code.

@arouinfar
Copy link

Discussed this with @DianaTavares and she will work on updating the icons, as time allows.

@arouinfar arouinfar assigned DianaTavares and unassigned arouinfar Apr 4, 2018
@DianaTavares
Copy link

This are the icons
fluid pressure and flow icons_pressure-icon
fluid pressure and flow icons_pressure-icon-navbar
fluid pressure and flow icons_flow-icon
fluid pressure and flow icons_flow-icon-navbar
fluid pressure and flow icons_water-tower-icon
fluid pressure and flow icons_water-tower-icon-navbar

what do you think?

@arouinfar
Copy link

Thanks @DianaTavares! I think these icons will do for now. Looks like some of the .png dimensions were off by a px or two, so I've resized them:

pressure-screen-icon.png
pressure-navbar-icon.png

flow-screen-icon.png
flow-navbar-icon.png

water-tower-screen-icon.png
water-tower-navbar-icon.png

The updated .ai asset (now 463 KB) for the icons can be found here:
https://drive.google.com/drive/folders/0B6CMwxdP0NGYSHVaeFNsbkJkWlU

@ariel-phet can you review and reassign the appropriate dev?

@arouinfar arouinfar assigned ariel-phet and unassigned DianaTavares May 15, 2018
@ariel-phet
Copy link

@arouinfar these look good, but currently this sim (unfortunately) has no planned work. I will keep it on the radar for an intern or new hire or such.

@ariel-phet ariel-phet removed their assignment May 18, 2018
@arouinfar
Copy link

Understood @ariel-phet. If any issues arise from the large file size of the assets that are checked in, a dev can replace them with the assets in #161 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants