resolve jump direction and arrow cue display directions, see #148

phetsims · Jan 11, 2019 · f42ce55 · f42ce55
1 parent 160cd70
commit f42ce55
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/js/faradays-law/view/MagnetNodeWithField.js b/js/faradays-law/view/MagnetNodeWithField.js
@@ -15,6 +15,7 @@ define( require => {
   const faradaysLaw = require( 'FARADAYS_LAW/faradaysLaw' );
   const FaradaysLawA11yStrings = require( 'FARADAYS_LAW/FaradaysLawA11yStrings' );
   const FaradaysLawAlertManager = require( 'FARADAYS_LAW/faradays-law/view/FaradaysLawAlertManager' );
+  const FaradaysLawConstants = require( 'FARADAYS_LAW/faradays-law/FaradaysLawConstants' );
   const FaradaysLawKeyboardDragListener = require( 'FARADAYS_LAW/faradays-law/view/FaradaysLawKeyboardDragListener' );
   const FocusHighlightFromNode = require( 'SCENERY/accessibility/FocusHighlightFromNode' );
   const JumpMagnitudeArrowNode = require( 'FARADAYS_LAW/faradays-law/view/JumpMagnitudeArrowNode' );
@@ -32,6 +33,10 @@ define( require => {
   const barMagnetString = FaradaysLawA11yStrings.barMagnet.value;
   const moveInFourDirectionsString = FaradaysLawA11yStrings.moveInFourDirections.value;
 
+  // constants
+  const HALF_MAGNET_WIDTH = FaradaysLawConstants.MAGNET_WIDTH / 2;
+  const HALF_MAGNET_HEIGHT = FaradaysLawConstants.MAGNET_HEIGHT / 2;
+
   /**
    * @param {FaradaysLawModel} model
    * @param {Tandem} tandem
@@ -172,7 +177,8 @@ define( require => {
 
             const magnitude = Number( domEvent.key );
 
-            if ( model.magnet.positionProperty.get().x <= ( model.bounds.maxX / 2 ) ) {
+            const dragBoundsMax = model.bounds.erodedXY( HALF_MAGNET_WIDTH, HALF_MAGNET_HEIGHT ).maxX;
+            if ( model.magnet.positionProperty.get().x < ( dragBoundsMax / 2 ) ) {
               // point to right
               rightJumpArrows.showCue( magnitude );
             }