Skip to content

Commit

Permalink
change let -> const if not reassigned, phetsims/tasks#973
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Dec 12, 2018
1 parent 197a935 commit 72e12b6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions js/faradays-law/view/MagnetDescriber.js
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ define( function( require ) {
getFlipMagnetAlertText( orientation ) {
let northSide = leftString;
let southSide = rightString;
let alertPattern = flippingMagnetPatternString;
const alertPattern = flippingMagnetPatternString;

if ( orientation === OrientationEnum.SN ) {
northSide = rightString;
Expand All @@ -221,17 +221,17 @@ define( function( require ) {
}

get strengthThroughFourCoilText() {
let strength = FIELD_STRENGTHS[ this.regionManager.getBottomCoilFieldStrengthRegion() ];
const strength = FIELD_STRENGTHS[ this.regionManager.getBottomCoilFieldStrengthRegion() ];
return StringUtils.fillIn( fieldStrengthPassingCoilPatternString, { strength: strength, coil: theFourLoopCoilString } );
}

get strengthThroughTwoCoilText() {
let strength = FIELD_STRENGTHS[ this.regionManager.getTopCoilFieldStrengthRegion() ];
const strength = FIELD_STRENGTHS[ this.regionManager.getTopCoilFieldStrengthRegion() ];
return StringUtils.fillIn( fieldStrengthPassingCoilPatternString, { strength: strength, coil: theTwoLoopCoilString } );
}

get strengthThroughBothCoilsText() {
let strength = FIELD_STRENGTHS[ this.regionManager.getTopCoilFieldStrengthRegion() ];
const strength = FIELD_STRENGTHS[ this.regionManager.getTopCoilFieldStrengthRegion() ];
return StringUtils.fillIn( fieldStrengthPassingBothCoilsPatternString, { strength: strength } );
}

Expand Down
2 changes: 1 addition & 1 deletion js/faradays-law/view/MagnetRegionsTests.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ define( function( require ) {

let x = columnWidth / 2; // center of col 1
let y = rowHeight / 2; // center of row 1
let v = new Vector2( x, y );
const v = new Vector2( x, y );

test( 'get column numbers', assert => {
assert.equal( MagnetRegionManager.getColumn( x ), 0, `${x} is in column 0` );
Expand Down

0 comments on commit 72e12b6

Please sign in to comment.