Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clipArea bug for screen icons #89

Closed
pixelzoom opened this issue Feb 29, 2024 · 3 comments
Closed

clipArea bug for screen icons #89

pixelzoom opened this issue Feb 29, 2024 · 3 comments
Assignees
Labels
type:bug Something isn't working

Comments

@pixelzoom
Copy link
Contributor

Breaking this issue out of #28 ...

The screen icons for the Pickup Coil and Transformer screens are not respecting clipArea.

On macOS 14.3.1, this problem occurs in both Chrome 122 and Firefox 123, but does NOT occur in Safari.

The first screenshot below shows the screen icons when the sim is started. The second screenshot below shows what happens when you leave the home screen, then come back to the home screen.

@jonathanolson is on the case. The backup plan is to convert those icons to images using rasterize().

screenshot_3066 screenshot_3067
@jonathanolson
Copy link
Contributor

Commit above I believe should fix this. @pixelzoom can you verify?

Looks related to phetsims/scenery#1548.

@pixelzoom
Copy link
Contributor Author

Yep, confirmed - that fixed it. Thanks! Closing.

@phet-dev
Copy link
Contributor

phet-dev commented Mar 5, 2024

Reopening because there is a TODO marked for this issue.

@phet-dev phet-dev reopened this Mar 5, 2024
pixelzoom added a commit that referenced this issue Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants