Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine dragSpeed and shiftDragSpeed for draggable objects #79

Closed
arouinfar opened this issue Feb 6, 2024 · 4 comments
Closed

Determine dragSpeed and shiftDragSpeed for draggable objects #79

arouinfar opened this issue Feb 6, 2024 · 4 comments

Comments

@arouinfar
Copy link
Contributor

@pixelzoom wrote in #54 (comment)

For tuning drag speeds, I added query parameter dragVelocity (default 500) and shiftVelocity (default 250). Since they affect all draggable objects, they should be used to tune one object at a time.

The query parameters have since been updated to dragSpeed and shiftDragSpeed. KeyboardDragListener currently supports two drag speeds, but a third speed has been proposed in phetsims/scenery#1601.

For now, I will focus on just the two supported speeds, and we can reassess if/when the third speed is added to KeyboardDragListener. I will also consider using different speeds for the measurement tools (compass and field meter) and the experimental equipment (magnets, coils).

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 8, 2024

@arouinfar here's a table that you can fill in:

Component dragSpeed shiftDragSpeed
Bar Magnet 600 150
Electromagnet 600 150
Pickup Coil 600 150
Compass 150 50
Field Meter 150 50

@arouinfar
Copy link
Contributor Author

Thanks for the table @pixelzoom, I've filled it out.

I chose slower speeds overall for the Compass and Field Meter. The rationale is that I want the dragSpeed to be slow enough to still be readable but not inconveniently slow. Additionally, the smaller the shiftDragSpeed, the more precisely the tools can be placed, which seems important.

We may need to refine these values as sound is integrated, but I tested these speeds with #77 and it sounded reasonable to me.

@arouinfar arouinfar assigned pixelzoom and unassigned arouinfar Feb 15, 2024
@pixelzoom
Copy link
Contributor

Thanks @arouinfar. These values feel good to me, implemented in e855aa5. It was also necessary to delete ?dragSpeed and ?shiftDragSpeed. Back to you for a look, feel free to close.

@arouinfar
Copy link
Contributor Author

Looks good on main, thanks @pixelzoom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants