Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect focus rectangle and interactive highlight for electromagnet #44

Closed
pixelzoom opened this issue Jan 8, 2024 · 6 comments
Closed

Comments

@pixelzoom
Copy link
Contributor

The electromagnetic has 2 choices of current source: battery or AC power supply. When the battery is selected, the focus rectangle is incorrect:

screenshot_2965

When the AC power supply is selected, the focus rectangle is correct:

screenshot_2966

Perhaps the focus rectangle is being computed based on boundsProperty instead of visibleBoundsProperty? @jessegreenberg thoughts?

@pixelzoom
Copy link
Contributor Author

The electromagnet is ElectromagnetNode.

@jessegreenberg
Copy link
Contributor

Yes, it seems the default highlights should surround the visibleBounds instead of just the bounds. I made phetsims/scenery#1593 for that change.

@pixelzoom
Copy link
Contributor Author

Interactive highlights have the same problem, so updating the title of this issue.

@pixelzoom pixelzoom changed the title Incorrect focus rectangle for electromagnet Incorrect focus rectangle and interactive highlight for electromagnet Jan 17, 2024
@pixelzoom
Copy link
Contributor Author

@jessegreenberg It looks like this is working correctly now -- the focus rectangle and interactive hightlight are the correct size. Was it fixed in some other general issue?

@jessegreenberg
Copy link
Contributor

Yes, this was fixed in phetsims/scenery#1593 so I would expect it to be fixed for this issue now.

@pixelzoom
Copy link
Contributor Author

Great, thanks. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants