Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative Input #14

Closed
pixelzoom opened this issue Oct 29, 2023 · 5 comments
Closed

Alternative Input #14

pixelzoom opened this issue Oct 29, 2023 · 5 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Oct 29, 2023

Alternative input is currently enabled, via this line in package.json:

      "supportsInteractiveDescription": true,

Alternative input for this sim looks pretty straightforward.

The Generator screen has a faucet. So if we want this sim to support alt input, phetsims/scenery-phet#773 needs to be addressed. It would be a shame to do work on alt input for this sim, then turn it off like we did for pH Scale.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Dec 4, 2023

12/4/2023 design meeeting: @arouinfar @ariel-phet @kathy-phet @brent-phet @pixelzoom

Work on FaucetNode (phetsims/scenery-phet#773) is anticipated to start in Feb 2024. That should be soon enough to make the milestone of "1.0 release in Summer 2024".

@pixelzoom
Copy link
Contributor Author

If I want to experiment with FaucetNode, I could do so in my subclass like this:

export default class WaterFaucetNode extends AccessibleSlider( FaucetNode, 3 ) {

@arouinfar
Copy link
Contributor

arouinfar commented Jan 17, 2024

@pixelzoom I reviewed the current state of alt input on main. Overall things look good including focus order and slider step sizes.

There are a few things that still need to be worked out, perhaps these should be moved to other issues?

  • Alternative input design for FaucetNode scenery-phet#773 (kickoff meeting tomorrow)
  • Electromagnet moves when using arrow keys to adjust sliders
  • Focus highlights for electromagnet and pickup coil include padding for hidden features (AC Power Supply, voltage readout)
  • Faraday's Law-like shortcuts to slide magnet through the coil
  • Interactive highlights for draggable objects in the Play Area aren't hooked up yet.

@arouinfar arouinfar assigned pixelzoom and unassigned kathy-phet and arouinfar Jan 17, 2024
@pixelzoom
Copy link
Contributor Author

Tracking for this sim in #55

-[ ] Electromagnet moves when using arrow keys to adjust sliders

Reported in #45, a common-code bug assigned to @jessegreenberg.

  • Focus highlights for electromagnet and pickup coil include padding for hidden features (AC Power Supply, voltage readout)

Reported in #44, a common-code bug assigned to @jessegreenberg.

  • Faraday's Law-like shortcuts to slide magnet through the coil

I had planned to handle this in #25, see #25 (comment). But since it's really independent of #25, I've moved it to #54.

  • Interactive highlights for draggable objects in the Play Area aren't hooked up yet.

Tracking in #53.

@pixelzoom
Copy link
Contributor Author

All of the issues that @arouinfar enumerated above have been addressed and closed. All remaining work for alt input is related to the Generator faucet, tracked in #55. So closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants