-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label on battery goes beyond orange end #202
Comments
The commits above are a little odd, because I accidentally made the change with generator 1.0 checkout out (forgot to checkout main after a patch for a different issue). 20e2497 is the primary commit, accidentally made in the "generator-1.0" branch of faradays-electromagnet-lab. The other commits are patches to main and the other branches. I patched all sims in the suite (including generator and magnet-and-compass) due to the weirdness of the primary commit. |
@KatieWoe thanks for finding this. Please review in master. If it looks OK, unassign yourself and change the status label to "status:fixed-awaiting-deploy". Note that the copper end of the batter is now a little wider, so there's more room for the voltage value, and we can use a slightly larger font to improve readability. (I cleared this change with @arouinfar.) |
Looks good on main |
To verify this issue in phetsims/qa#1128 and phetsims/qa#1130... Run the sim with It is sufficient to test this on 1 platform. Close this issue if everything is OK. |
Looks good in 1.0.0-rc.2 for FEL and for Magnets and Electromagnets. |
For phetsims/qa#1116. If the string for the voltage label on the battery gets too long it goes off the orange end. If the voltage is negative it goes off the battery.
The text was updated successfully, but these errors were encountered: