Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label on battery goes beyond orange end #202

Closed
Tracked by #1128 ...
KatieWoe opened this issue Jul 25, 2024 · 5 comments
Closed
Tracked by #1128 ...

Label on battery goes beyond orange end #202

KatieWoe opened this issue Jul 25, 2024 · 5 comments
Labels

Comments

@KatieWoe
Copy link

For phetsims/qa#1116. If the string for the voltage label on the battery gets too long it goes off the orange end. If the voltage is negative it goes off the battery.
toolong2
toolong

@KatieWoe KatieWoe added the type:bug Something isn't working label Jul 25, 2024
pixelzoom added a commit that referenced this issue Jul 25, 2024
pixelzoom added a commit that referenced this issue Jul 25, 2024
pixelzoom added a commit that referenced this issue Jul 25, 2024
pixelzoom added a commit to phetsims/generator that referenced this issue Jul 25, 2024
pixelzoom added a commit that referenced this issue Jul 25, 2024
pixelzoom added a commit to phetsims/magnets-and-electromagnets that referenced this issue Jul 25, 2024
pixelzoom added a commit that referenced this issue Jul 25, 2024
pixelzoom added a commit to phetsims/magnet-and-compass that referenced this issue Jul 25, 2024
@pixelzoom
Copy link
Contributor

The commits above are a little odd, because I accidentally made the change with generator 1.0 checkout out (forgot to checkout main after a patch for a different issue). 20e2497 is the primary commit, accidentally made in the "generator-1.0" branch of faradays-electromagnet-lab. The other commits are patches to main and the other branches. I patched all sims in the suite (including generator and magnet-and-compass) due to the weirdness of the primary commit.

@pixelzoom
Copy link
Contributor

@KatieWoe thanks for finding this. Please review in master. If it looks OK, unassign yourself and change the status label to "status:fixed-awaiting-deploy".

Note that the copper end of the batter is now a little wider, so there's more room for the voltage value, and we can use a slightly larger font to improve readability. (I cleared this change with @arouinfar.)

screenshot_3431 screenshot_3432

@KatieWoe
Copy link
Author

Looks good on main

@pixelzoom
Copy link
Contributor

To verify this issue in phetsims/qa#1128 and phetsims/qa#1130...

Run the sim with ?stringTest=dynamic. Verify that the voltage display (e.g. '9 V') on the battery stays within the bounds of the copper section of the battery. Test of the full range of positive and negative voltages.

It is sufficient to test this on 1 platform. Close this issue if everything is OK.

@Nancy-Salpepi
Copy link

Looks good in 1.0.0-rc.2 for FEL and for Magnets and Electromagnets.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants