-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Sound #15
Comments
12/4/2023 design meeeting: @arouinfar @ariel-phet @kathy-phet @brent-phet @pixelzoom CM: It would be nice to have a default common-code sound for draggable things. |
Over in phetsims/graphing-lines#137 (comment), @amanda-phet and I discovered draggable objects apparently have an (unofficial?) default sound design -- tambo's "grab" and "release" sounds. In the above commit, I've added those grab and release sounds to all objects that are draggable using the mouse or keyboard (DragListener or KeyboardDragListener). |
1/4/24 design meeting: Since the sim is nearing feature complete, it would be good to schedule a meeting about this issue "soon". |
We had a sound design kickoff meeting on 1/17/2024. Meeting notes, etc. live in https://docs.google.com/document/d/1IoQX0ybxgxso57yedPZB8NvkWuMLMBD71kO04k7hZHo/edit?pli=1#heading=h.qxxnnmfrpx3k. |
@arouinfar noted that we will need sound for FaucetNode. Since it's a common code component, we'll need default sounds, and the ability to override the defaults with sim-specific sounds. Brainstorming aspects that might need sound:
It will be useful for whoever is doing the sound design to consult the scenery-phet demo for FaucetNode, runnable from phetmarks, to see the important behaviors/options. EDIT: Tracking FaucetNode sound in phetsims/scenery-phet#840. |
This issue is tracking UI Sound, which is complete apart from phetsims/scenery-phet#840. We're currently working on full support for sound and sonification, so I don't think we need this issue anymore. Closing. |
UI Sound is currently enabled, via this line in package.json:
We’ll need to decide if we want any custom sound design, mainly for draggable objects. We’ve been punting on custom sound in other similar sims (e.g. Geometric Optics) so it might be OK to also punt here.
The text was updated successfully, but these errors were encountered: