change requests for maxEMF calibration, #66

phetsims · Jul 5, 2024 · c3c82af · c3c82af
1 parent e0e0c18
commit c3c82af
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/js/generator/model/Generator.ts b/js/generator/model/Generator.ts
@@ -61,7 +61,7 @@ export default class Generator extends PhetioObject {
         // Disable voltmeter kinematics for the generator. Immediate response is needed, due to the cyclic nature.
         kinematicsEnabledProperty: new BooleanProperty( false )
       },
-      maxEMF: 110000, // see PickupCoil.maxEMFProperty
+      maxEMF: 120000, // see PickupCoil.maxEMFProperty and https://github.com/phetsims/faradays-electromagnetic-lab/issues/66
       transitionSmoothingScale: 1, // see PickupCoil.transitionSmoothingScaleProperty
       samplePointsSpacing: this.turbine.barMagnet.size.height / 10, // similar to PickupCoilScreenModel
       fluxAreaCompensationEnabled: false, // see https://github.com/phetsims/faradays-electromagnetic-lab/issues/170

diff --git a/js/pickup-coil/model/PickupCoilScreenModel.ts b/js/pickup-coil/model/PickupCoilScreenModel.ts
@@ -57,7 +57,7 @@ export default class PickupCoilScreenModel extends FELScreenModel {
 
     this.pickupCoil = new PickupCoil( barMagnet, preferences.currentFlowProperty, {
       position: PICKUP_COIL_POSITION,
-      maxEMF: 1000000, // see PickupCoil.maxEMFProperty
+      maxEMF: 1300000, // see PickupCoil.maxEMFProperty and https://github.com/phetsims/faradays-electromagnetic-lab/issues/66
       transitionSmoothingScale: 0.77, // see PickupCoil.transitionSmoothingScaleProperty
 
       // To avoid inducing significant (incorrect) EMF when the magnet is moved vertically when inside the coil,

diff --git a/js/transformer/model/Transformer.ts b/js/transformer/model/Transformer.ts
@@ -50,7 +50,7 @@ export default class Transformer extends PhetioObject {
 
     this.pickupCoil = new PickupCoil( this.electromagnet, currentFlowProperty, {
       position: options.pickupCoilPosition,
-      maxEMF: 5000000, // see PickupCoil.maxEMFProperty
+      maxEMF: 3500000, // see PickupCoil.maxEMFProperty and https://github.com/phetsims/faradays-electromagnetic-lab/issues/66
       transitionSmoothingScale: 0.45, // see PickupCoil.transitionSmoothingScaleProperty
 
       // To avoid inducing significant (incorrect) EMF when the magnet is moved vertically when inside the coil,