Skip to content

Commit

Permalink
delete piecewiseCutoff query parameter, #77
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Mar 13, 2024
1 parent 03f5307 commit 4728547
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
9 changes: 0 additions & 9 deletions js/common/FELQueryParameters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

import logGlobal from '../../../phet-core/js/logGlobal.js';
import faradaysElectromagneticLab from '../faradaysElectromagneticLab.js';
import FELConstants from './FELConstants.js';

export const MagneticUnitsValues = [ 'G', 'T' ] as const;
export type MagneticUnits = ( typeof MagneticUnitsValues )[number];
Expand Down Expand Up @@ -56,14 +55,6 @@ const SCHEMA_MAP = {
// Prints info to the console that is useful for calibrating the pickup coil. See PickupCoil.calibrateEMF.
calibrateEMF: {
type: 'flag'
},

// Field magnitude cutoff value in G, used for FieldMeterDragSonifier.fieldMagnitudeToPlaybackRatePiecewiseLinear
//TODO https://github.com/phetsims/faradays-electromagnetic-lab/issues/77 delete this
piecewiseCutoff: {
type: 'number',
defaultValue: 20,
isValidValue: ( value: number ) => FELConstants.MAGNET_STRENGTH_RANGE.contains( value )
}
} as const;

Expand Down
3 changes: 1 addition & 2 deletions js/common/view/FieldMeterDragSonifier.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import Vector2 from '../../../../dot/js/Vector2.js';
import felFieldMeterLoop_mp3 from '../../../sounds/felFieldMeterLoop_mp3.js';
import Utils from '../../../../dot/js/Utils.js';
import FieldNode from './FieldNode.js';
import FELQueryParameters from '../FELQueryParameters.js';
import FELSonifier from '../model/FELSonifier.js';
import DerivedProperty from '../../../../axon/js/DerivedProperty.js';
import Property from '../../../../axon/js/Property.js';
Expand Down Expand Up @@ -93,7 +92,7 @@ export default class FieldMeterDragSonifier extends FELSonifier implements TInpu
private static fieldMagnitudeToPlaybackRatePiecewiseLinear( fieldMagnitude: number, fieldMagnitudeRange: Range ): number {
assert && assert( fieldMagnitudeRange.contains( fieldMagnitude ), `invalid fieldMagnitude: ${fieldMagnitude}` );

const piecewiseCutoff = FELQueryParameters.piecewiseCutoff; // G
const piecewiseCutoff = 20; // G
assert && assert( fieldMagnitudeRange.contains( piecewiseCutoff ), `invalid piecewiseCutoff: ${piecewiseCutoff}` );

let playbackRate: number;
Expand Down

0 comments on commit 4728547

Please sign in to comment.