Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is doc/model.md needed for this sim? #93

Closed
jonathanolson opened this issue May 23, 2017 · 2 comments
Closed

Is doc/model.md needed for this sim? #93

jonathanolson opened this issue May 23, 2017 · 2 comments
Assignees
@jonathanolson
Labels
dev:code-review

Comments

@jonathanolson
Copy link
Contributor

Usually we have a very simple description if there isn't anything complicated going on.

For the code review #88
jbphet added a commit that referenced this issue May 24, 2017
@jbphet
added a model.md document, see #93
425cfe4
@jbphet
Copy link
Contributor

jbphet commented May 24, 2017

Originally I had thought that this sim didn't need a model.md file since there isn't really a sophisticated underlying model, but after looking around at other similar simulations I felt like yes, we should probably have a model description document. I've written something up, @jonathanolson - please have a look and close this if you feel it is sufficient.

@jonathanolson
Copy link
Contributor Author

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @jbphet