Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer areas #100

Closed
jonathanolson opened this issue Jun 6, 2017 · 5 comments
Closed

Pointer areas #100

jonathanolson opened this issue Jun 6, 2017 · 5 comments
Assignees

Comments

@jonathanolson
Copy link
Contributor

Very few are overridden. Has the sim been vetted for what touch areas should be expanded?

Code review from #88

@jbphet
Copy link
Contributor

jbphet commented Jun 9, 2017

I made some minor adjustments, and tested on iPad 2, and it all feels pretty usable to me. Assigning to @phet-steele for verification on upcoming dev release.

@jbphet jbphet assigned phet-steele and unassigned jbphet Jun 9, 2017
@amanda-phet
Copy link
Contributor

1 and -1 look funny on the Negatives screen.

Also, I know that with a toggle you can generally click the images next to the toggle instead of dragging the actual toggle knob. I don't see the touch areas outlined with the query parameter but I can check on an iPad to see that they are functioning ok.

@amanda-phet
Copy link
Contributor

Confirmed with iPad that the touch areas for the toggle are not large enough (or existent?). Can we make sure that the images for the coin and x are comfortably large for touch?

Currently, only the toggle knob has a larger touch area:
screen shot 2017-06-22 at 1 53 31 pm

@jbphet
Copy link
Contributor

jbphet commented Jun 22, 2017

As for 1 and -1, I think @amanda-phet was seeing the pointer areas for items that were clipped from the carousel. I went ahead and added pointer areas to the constant coin terms though, just to avoid confusion, and it might make them more consistent to interact with.

As for the AB switch, I've expanded the touch areas for the nodes used and shifted these touch areas so that they don't overlap with that of the switch, here's a screenshot with showPointerAreas turned on.

exex-touch

Back to you @amanda-phet.

@jbphet jbphet assigned amanda-phet and unassigned jbphet Jun 22, 2017
@phet-steele
Copy link
Contributor

@amanda-phet likes the touch areas in dev.4, and so do I.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants