-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test for memory leaks #64
Comments
See #86 for possible leak in the game. |
@pixelzoom I went ahead and took snapshots while running https://phet-dev.colorado.edu/html/equality-explorer/1.0.0-dev.111/phet/equality-explorer_all_phet.html?fuzzMouse. Looks like you had a steep initial climb (probably from entering all the screens for the first time), but then stabilized over the remaining minutes. The larger snapshots had more things on the screen at the moment of recording, which is a likely explanation. EDIT: after 30 & 50 min tests, might have a tiny leek.
|
Signed-off-by: Chris Malley <[email protected]>
Signed-off-by: Chris Malley <[email protected]>
I added query parameters |
Testing the Variables screen is sufficient for testing the Basics, Numbers, and Lab screens. They all use the same "code paths". Below are Chrome 67 heap snapshots (macOS 10.11.6) for the Variables screen with
|
The Operations screen uses code paths not used in the Variables et al. screens. Specifically, it adds the universal operation and it combines like terms on the plates (which involves a different drag listener subtype, Below are Chrome 67 heap snapshots (macOS 10.11.6) for the Operations screen with
|
The Solve It! screen shares code with other screens, but has code paths that are unique to this screen. Below are Chrome 67 heap snapshots (macOS 10.11.6) for the Solve It! screen with But... For this screen,
|
To further test the Solve It! screen, I followed a procedure similar to what @phet-steele did in #86. I manually played all 4 levels, in order. When I had solved 11 challenges (and had seen the Reward after the 10th solution) I took a heap snapshot and went on to the next level. After completing all 4 levels, I pressed the Reset All button, and took another heap snapshot. Then I repeated the entire process. Below are Chrome 67 heap snapshots (macOS 10.11.6) for the Solve It! screen with
|
Finally, I tested with all screens, using
|
This issue is to record the results of memory leak testing, and identify any issues.
The text was updated successfully, but these errors were encountered: