Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sim may freeze when mouse leaves iframe #322

Closed
KatieWoe opened this issue May 4, 2021 · 7 comments
Closed

Sim may freeze when mouse leaves iframe #322

KatieWoe opened this issue May 4, 2021 · 7 comments
Labels

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented May 4, 2021

Test device
Dell and Mac
Operating System
Win 10 and MacOS 11
Browser
Chrome and Safari
Problem description
For phetsims/qa#642. Wasn't able to recreate on published, so it seems connected to the fix. When dragging an object (or even dragging nothing) outside the iframe and letting go, the sim freezes and throws a console error.

Visuals
error
releaseoutofiframe

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Energy Skate Park‬
URL: https://phet-dev.colorado.edu/html/energy-skate-park/1.1.2-rc.1/phet/energy-skate-park_en_phet.html
Version: 1.1.2-rc.1 2021-04-23 18:39:40 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.93 Safari/537.36
Language: en-US
Window: 1280x658
Pixel Ratio: 1.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@Matthew-Moore240
Copy link

I was also experiencing this exact issue on Win 10 chrome.

@jonathanolson
Copy link
Contributor

I believe this is handled with the above commit (using master's copy of interrupt inline), can you try https://phet-dev.colorado.edu/html/energy-skate-park/1.1.2-rc.3/phet/energy-skate-park_en_iframe_phet.html

@KatieWoe
Copy link
Contributor Author

KatieWoe commented May 5, 2021

Looks ok in the above link

@KatieWoe KatieWoe assigned jonathanolson and unassigned KatieWoe May 5, 2021
@jonathanolson
Copy link
Contributor

Sounds good, closing this issue.

@KatieWoe
Copy link
Contributor Author

This is back in phetsims/qa#649
comebackagain

@KatieWoe KatieWoe reopened this May 17, 2021
@jonathanolson
Copy link
Contributor

Looks like this is mainly due to me not updating it to rc.3 in the maintenance internals, should be handled. Will verify with next test.

@jonathanolson jonathanolson removed their assignment May 24, 2021
@jonathanolson
Copy link
Contributor

Closing, handled in maintenance release deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants