Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravity on Jupiter is incorrect #247

Closed
arouinfar opened this issue Apr 1, 2020 · 4 comments
Closed

Gravity on Jupiter is incorrect #247

arouinfar opened this issue Apr 1, 2020 · 4 comments

Comments

@arouinfar
Copy link
Contributor

Observed in master and the prototype. When selecting Jupiter from the gravity ComboBox, the displayed value is 26.0 m/s^2. However, the value of gravity on Jupiter should be 24.8 m/s^2.

@jessegreenberg
Copy link
Contributor

Interesting, thanks @arouinfar. Master is currently using the value that was used in the java sim (25.95 N/kg). Fixed in the above commit.

The range of allowable gravity is currently 1 - JUPITER_GRAVITY. So this reduced the gravity range just a little bit, is that OK?

Does the version available as the "prototype" need to be updated with this fix?

@arouinfar
Copy link
Contributor Author

Master is currently using the value that was used in the java sim (25.95 N/kg).

Oh wow, looks like Java was incorrect for all these years!

The range of allowable gravity is currently 1 - JUPITER_GRAVITY. So this reduced the gravity range just a little bit, is that OK?

I don't think the calculation is currently working in master, because the max is now JUPITER_GRAVITY. Does the range need to reference JUPITER_GRAVITY? I think a max of 26.0 was fine.

image

@arouinfar arouinfar assigned jessegreenberg and unassigned arouinfar Apr 1, 2020
@arouinfar
Copy link
Contributor Author

Does the version available as the "prototype" need to be updated with this fix?

Once this issue is worked out, it might be nice to republish if master is in a good place.

@jessegreenberg
Copy link
Contributor

I think a max of 26.0 was fine.

OK sounds good. Lets publish a new version after #240 is done, unless it is important to fix this right away, @arouinfar let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants