Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

' => { return ' is bad text #140

Closed
zepumph opened this issue Nov 1, 2019 · 2 comments
Closed

' => { return ' is bad text #140

zepumph opened this issue Nov 1, 2019 · 2 comments
Assignees
@jessegreenberg

Comments

@zepumph
Copy link
Member

zepumph commented Nov 1, 2019

Because of work in phetsims/chipper#791, this lint rule has been broken, but commits in phetsims/chipper#808 fixed it, and I saw a few errors in this repo (and basics).

@jessegreenberg assigning over to you to fix a few lint rules. You can do so by uncommenting the last rule in bad-text.js (the one marked with the todo pointing to this issue). Please fix lint rules and then commit that rule uncommented to master. Thanks!
@zepumph zepumph mentioned this issue Nov 1, 2019
Closed
@jessegreenberg jessegreenberg mentioned this issue Nov 1, 2019
Closed
jessegreenberg added a commit that referenced this issue Nov 8, 2019
@jessegreenberg
fix bad-text for #140
0c9be7d
@jessegreenberg
Copy link
Contributor

Fixed in this sim, Ill un-comment rule and commit to master next.

jessegreenberg added a commit to phetsims/molecules-and-light that referenced this issue Nov 8, 2019
@jessegreenberg
() => return is bad text, see phetsims/energy-skate-park#140
a88823d
jessegreenberg added a commit to phetsims/mobius that referenced this issue Nov 8, 2019
@jessegreenberg
'() => { return' is bad text, see phetsims/energy-skate-park#140
786ab38
jessegreenberg added a commit to phetsims/chipper that referenced this issue Nov 8, 2019
@jessegreenberg
uncomment ' => { return ' in bad text, see phetsims/energy-skate-park…
8e72946 
…#140
@jessegreenberg
Copy link
Contributor

OK, fixed in a few different places (energy-skate-park, molecules-and-light, mobius) and uncommented the rule. I think this can be closed.

jessegreenberg added a commit that referenced this issue Nov 8, 2019
@jessegreenberg
syntax fix after #140
d59670d
zepumph pushed a commit to phetsims/perennial that referenced this issue Oct 22, 2024
@jessegreenberg @zepumph
uncomment ' => { return ' in bad text, see phetsims/energy-skate-park…
ff2cf29 
…#140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph