Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make subdirectory for each screen under js/ #10

Closed
jessegreenberg opened this issue Jun 14, 2018 · 5 comments
Closed

Make subdirectory for each screen under js/ #10

jessegreenberg opened this issue Jun 14, 2018 · 5 comments
Assignees
@jessegreenberg

Comments

@jessegreenberg
Copy link
Contributor

From phetsims/energy-skate-park-basics#400

From code review checklist:

All JavaScript source should be in the js/ directory. There should be a subdirectory for each screen

At the moment all code is under js/energy-skate-park-basics.

We will have to be careful about keeping history during this
@jessegreenberg jessegreenberg self-assigned this Jun 14, 2018
jessegreenberg added a commit that referenced this issue Oct 4, 2018
@jessegreenberg
move ControlPoint to common model directory, see #10
ae57466
jessegreenberg added a commit that referenced this issue Oct 4, 2018
@jessegreenberg
move DebugTracks to common, see #10
d0be036
jessegreenberg added a commit that referenced this issue Oct 4, 2018
@jessegreenberg
Move EnergySkateParkModel to common, see #10
5672616
jessegreenberg added a commit that referenced this issue Oct 4, 2018
@jessegreenberg
move EnergySkateParkModelIO.js to common, see #10
d182b87
jessegreenberg added a commit that referenced this issue Oct 4, 2018
@jessegreenberg
move Skater and SkaterState to common, see #10
7650930
jessegreenberg added a commit that referenced this issue Oct 4, 2018
@jessegreenberg
move spline evaluation to common, see #10
28b3f7f
jessegreenberg added a commit that referenced this issue Oct 4, 2018
@jessegreenberg
move Track, TrackIO, and TrackReferenceIO to common/model, see #10
7123e55
@jessegreenberg
Copy link
Contributor Author

There are a few lingering files that still are oustide of where they should be Ill move them now.

@jessegreenberg
Copy link
Contributor Author

jessegreenberg commented Sep 10, 2019 •
edited
Loading

I don't see any usages of EnergySkateParkScreen, can it be deleted?

EDIT: Deleting it.

jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
move files to common/, delete unused file, see #10
08137c5
jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
grunt update after file renames, see #10
b33d9ed
@jessegreenberg
Copy link
Contributor Author

Everything under js/view needs to be moved, probably under js/common/view

jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
move AttachDetachToggleButtons.js to common, see #10
d99c4f1
jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
move BackgroundNode to common, see #10
9ba020e
jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
move ControlPointNode to common, see #10
746708e
jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
move ControlPointUI to common, see #10
a50611a
jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
EnergySkateParkColorScheme to common, see #10
4d75991
jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
move EnergySkateParkControlPanel to common, see #10
89e3d19
jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
Move GridNode to common, see #10
2c254b8
jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
PieChartLegend to common, see #10
b0acb26
jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
PieChartNode to common, see #10
c230a3a
jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
move PlaybackSpeedControl to common, see #10
56a11eb
jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
move SkaterNode to common, see #10
49b3dc8
jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
move TrackDragHandler to common, see #10
c7ae122
jessegreenberg added a commit that referenced this issue Sep 10, 2019
@jessegreenberg
Move TrackNode to common, see #10
e461346
@jessegreenberg
Copy link
Contributor Author

Everything has been moved out of /view to common/view with git mv to preserve history.

@jessegreenberg
Copy link
Contributor Author

Everything has been moved to a screen specific subdir or common now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessegreenberg