Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can proxy for save/load for the tracks for phetio.js be removed? #405

Closed
jessegreenberg opened this issue Feb 22, 2018 · 3 comments
Closed
Assignees

Comments

@jessegreenberg
Copy link
Contributor

This block is in EnergySkateParkBasicsModel

    // Proxy for save/load for the tracks for phetio.js
    // TODO: This is all a bit hackish, to serialize the tracks.  Cannot this be made simpler?
    if ( draggableTracks ) {
      //phetio && phetio.addInstance( 'playgroundScreen.tracks', {
      //  phetioID: 'playgroundScreen.tracks',
      //
      //  // TODO: use get value instead of this function.
      //  getArray: function() {
      //  },
      //
      //  get value() {
      //    return this.getArray();
      //  },
      //
      //  // TODO: set value asymmetric from getArray
      //  set value( arrayOfArrayOfVector ) {

      //  }
      //} );
    }

Not sure if we still want this around. @samreid would you like to keep this commented code?

@jessegreenberg
Copy link
Contributor Author

For #398.

@samreid
Copy link
Member

samreid commented Feb 23, 2018

It can be deleted now, thanks!

@jessegreenberg
Copy link
Contributor Author

Deleted, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants