Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teapot chunks load too close together studio #336

Closed
KatieWoe opened this issue Jun 30, 2020 · 4 comments
Closed

Teapot chunks load too close together studio #336

KatieWoe opened this issue Jun 30, 2020 · 4 comments
Assignees
Labels

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#488. Issue with State found in Studio.
When you have the teapot turned on to a small degree the chunks are spread out. However, when you then launch the sim, the chunks load close together, as if the teapot was fully on.
teapottooclose

@chrisklus
Copy link
Contributor

Nice catch @KatieWoe, thanks! The preloading of the energy chunks was only dependent on the tea kettle's internal energy, so if the burner was on really low but the tea kettle was hot, the chunks would load close together. I matched the behavior so that if the burner is on, the chunks are preloaded using the burner setting. If the burner is off (but the tea kettle is still warm), then it bases the chunks off of its internal energy.

I've tested this a bit on my own, but will mark for QA to verify in the RC.

@KatieWoe
Copy link
Contributor Author

This looks ok in phetsims/qa#528. Will reopen if something comes up.

@jbphet
Copy link
Contributor

jbphet commented Sep 24, 2020

Reopening to test on 1.4.0-rc.2, since the way that energy chunk state is handled has been completely revamped.

@KatieWoe
Copy link
Contributor Author

This does not seem to occur in rc.2 will reopen if something comes up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants