Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge slowdown in state wrapper #328

Closed
ghost opened this issue Apr 9, 2020 · 3 comments
Closed

Huge slowdown in state wrapper #328

ghost opened this issue Apr 9, 2020 · 3 comments
Assignees

Comments

@ghost
Copy link

ghost commented Apr 9, 2020

Test Device

MacBook Air, Early 2015, 1.6 GHz Dual-Core Intel Core i5

Operating System

macOS 10.15.2

Browser

Safari 13.0.4

Problem Description

For phetsims/qa#488. In https://phet-dev.colorado.edu/html/energy-forms-and-changes/1.2.0-dev.12/phet-io/, I'm seeing a huge slowdown in the state wrapper on my MacBook Air. When I use the profiler query parameter, I can get the FPS down to 2 pretty quickly. The blocks like to float on their own for a few seconds. It's pretty unusable.

Visuals

issue

@ghost ghost added the type:performance label Apr 9, 2020
@ghost ghost assigned chrisklus Apr 9, 2020
@ghost
Copy link
Author

ghost commented Apr 9, 2020

The playback in mirror inputs can also be slow, but not nearly as slow as state.

@chrisklus
Copy link
Contributor

Thanks @lmulhall-phet - the state wrapper is indeed pretty unusable when loaded with numberOfMillisecondsBetweenUpdates at its default value of 1000 ms, see #316 and the phet-io special instruction section in phetsims/qa#488.

The state slowness doesn't relate to the mirror inputs wrapper though, so if you think #328 (comment) warrants an issue of its own, please create one. Feel free to close when you see this!

@ghost
Copy link
Author

ghost commented Apr 9, 2020

Ah, sorry I didn't see that. Thanks, @chrisklus.

@ghost ghost closed this as completed Apr 9, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant