Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link system element's visibility to corresponding radio button's visibility #305

Closed
chrisklus opened this issue Jan 8, 2020 · 1 comment
Assignees

Comments

@chrisklus
Copy link
Contributor

From 01/07/20 EFAC PhET-iO design meeting, for #216.

The current way to remove a system element (the tea kettle, for example) from one of the carousels in Studio is to make the tea kettle radio button visible: false, as well as the teaKettleNode itself visible: false so that you don't see it go by when selecting an element on either side of the tea kettle.

@arouinfar and @kathy-phet would prefer to not have to explain this to phet-io clients or make them deal with it, so they proposed linking the visibility of the system elements to the visibility of the radio buttons, so all clients will need to do is hide a given radio button, and the rest is taken care of. We should then make the visibleProperty of the system element nodes phetioReadOnly: true so that phet-io clients can't accidentally break this relationship.

@chrisklus
Copy link
Contributor Author

I was able to do this without passing in all of the energy system nodes to EnergySystemElementSelector (where the visibility's are being linked), so this change worked out pretty cleanly. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant