Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect use of "property" #263

Closed
pixelzoom opened this issue Jul 31, 2019 · 1 comment
Closed

incorrect use of "property" #263

pixelzoom opened this issue Jul 31, 2019 · 1 comment
Assignees
@chrisklus
Labels
dev:code-review priority:3-medium

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 31, 2019 •
edited
Loading

Related to code review #247:

  • Differentiate between Property and "property" in comments. They are different things. Property is a type in AXON; property is any value associated with a JavaScript object. Often "field" can be used in exchange for "property" which can help with clarity.

Searching for "property" in comments, I see at least 7 occurrences that should be "Property".

Searching for "properties" in comments, I see at least 3 occurrences that should be "Properties".
@chrisklus chrisklus mentioned this issue Jul 31, 2019
Closed
chrisklus added a commit that referenced this issue Aug 29, 2019
@chrisklus
Capitalize usages of axon Property in comments, see #263
3e0c7b1
@chrisklus
Copy link
Contributor

The usages have been addressed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisklus chrisklus

Labels
dev:code-review priority:3-medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @chrisklus